linux-kernel - Re: [PATCH] drm/hisilicon: Deleted the drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50c87a77-ffdd-42d2-0747-69c95305a48f@suse.de>
Date:   Fri, 25 Sep 2020 09:26:42 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Tian Tao <tiantao6@...ilicon.com>, airlied@...ux.ie,
        daniel@...ll.ch, kraxel@...hat.com, alexander.deucher@....com,
        tglx@...utronix.de, dri-devel@...ts.freedesktop.org,
        xinliang.liu@...aro.org, linux-kernel@...r.kernel.org
Cc:     linuxarm@...wei.com
Subject: Re: [PATCH] drm/hisilicon: Deleted the drm_device declaration

Hi

Am 25.09.20 um 09:02 schrieb Thomas Zimmermann:
> Hi,
> 
> just a few nits.
> 
> Am 25.09.20 um 08:49 schrieb Tian Tao:
>> drm_framebuffer.h contains drm/drm_device.h and struct drm_device is
> 
> contains -> includes
> 
>> already declared in this file, so there is no need to declare struct
> 
> declared -> defined

Wait a second. drm_framebuffer.h actually declares struct drm_device,
but does not include <drm/device.h>. So the commit messag should say
something like

  drm_framebuffer.h already declares struct drm_device, so there's no
need to declare it in hibm_drm_drv.h

> 
>> drm_device in hibm_drm_drv.h.
>>
>> Signed-off-by: Tian Tao <tiantao6@...ilicon.com>
> 
> Acked-by: Thomas Zimmermann <tzimmermann@...e.de>
> 
>> ---
>>  drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
>> index 87d2aad..6a63502 100644
>> --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
>> +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h
>> @@ -22,8 +22,6 @@
>>  #include <drm/drm_fb_helper.h>
>>  #include <drm/drm_framebuffer.h>
>>  
>> -struct drm_device;
>> -
>>  struct hibmc_connector {
>>  	struct drm_connector base;
>>  
>>
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "signature.asc" of type "application/pgp-signature" (517 bytes)