linux-kernel - Re: [PATCH 6/8] arm64: dts: meson: disable vrtc for VIM3L boards meson-khadas-vim3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Sep 2020 09:44:32 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Artem Lapkin <email2tema@...il.com>
Cc:     khilman@...libre.com, robh+dt@...nel.org, jbrunet@...libre.com,
        martin.blumenstingl@...glemail.com, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org,
        art@...das.com, nick@...das.com, gouwa@...das.com
Subject: Re: [PATCH 6/8] arm64: dts: meson: disable vrtc for VIM3L boards
 meson-khadas-vim3

Hi,

On 25/09/2020 05:30, Artem Lapkin wrote:
> vrtc not used for meson-khadas-vim3
> 
> Signed-off-by: Artem Lapkin <art@...das.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> index 3111bf35c0f..81bb88a76d5 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> @@ -284,6 +284,10 @@ &pwm_ef {
>          pinctrl-names = "default";
>  };
>  
> +&vrtc {
> +	status = "disabled";
> +};
> +
>  &saradc {
>  	status = "okay";
>  	vref-supply = <&vddao_1v8>;
> 

The VRTC is one of the default suspend wake-up sources, so why would you disable it ?

If it collides with the real RTC, add aliases to move the vrtc in rtc1 and set the real RTC as rtc0.

 »       aliases·{
+»       »       rtc0·=·&rtc0;
+»       »       rtc1·=·&vrtc;
 »       };

Neil