linux-kernel - Re: [PATCH v6] cypto: mediatek - fix leaks in mtk_desc_ring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Sep 2020 18:11:17 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Xiaoliang Pang <dawning.pang@...il.com>
Cc:     davem@...emloft.net, matthias.bgg@...il.com, swboyd@...omium.org,
        yuehaibing@...wei.com, tianjia.zhang@...ux.alibaba.com,
        ryder.lee@...iatek.com, linux-crypto@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6] cypto: mediatek - fix leaks in mtk_desc_ring_alloc

On Mon, Sep 14, 2020 at 11:00:51AM +0800, Xiaoliang Pang wrote:
> In the init loop, if an error occurs in function 'dma_alloc_coherent',
> then goto the err_cleanup section, after run i--,
> in the array ring, the struct mtk_ring with index i will not be released,
> causing memory leaks
> 
> Fixes: 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some MediaTek chips")
> Cc: Ryder Lee <ryder.lee@...iatek.com>
> Signed-off-by: Xiaoliang Pang <dawning.pang@...il.com>
> ---
>  drivers/crypto/mediatek/mtk-platform.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt