linux-kernel - Re: [PATCH] btrfs: block-group: fix a doc warning in block-group.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5F6DA872.7000504@huawei.com>
Date:   Fri, 25 Sep 2020 16:21:06 +0800
From:   Xiaofei Tan <tanxiaofei@...wei.com>
To:     <dsterba@...e.cz>, <clm@...com>, <josef@...icpanda.com>,
        <dsterba@...e.com>, <linux-btrfs@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linuxarm@...wei.com>
Subject: Re: [PATCH] btrfs: block-group: fix a doc warning in block-group.c

Hi David,

On 2020/9/23 17:45, David Sterba wrote:
> On Tue, Sep 22, 2020 at 08:37:21PM +0800, Xiaofei Tan wrote:
>> Fix following warning caused by mismatch bewteen function parameters
>> and comments.
>> fs/btrfs/block-group.c:1649: warning: Function parameter or member 'fs_info' not described in 'btrfs_rmap_block'
> 
> IIRC there are way more formatting errors for the kernel-doc, so I'd
> rather fix them in one patch. Also for static functions or internal
> helpers the proper formatting is not that important as it's read by
> people and the acual parameters are what matters.
> 

Sure, there are many warnings in the other files from dir fs/btrfs/.
If fix them in one patch, it could be huge :)

> .
> 

-- 
 thanks
tanxiaofei