linux-kernel - Re: [PATCH] mmc: davinci: Drop pointer to mmc_host from mmc_davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFo-FHGs7Po5naNwhe9xEGfxfdJo2gnddpfOJ73YzTFTyA@mail.gmail.com>
Date:   Fri, 25 Sep 2020 13:31:32 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Amey Narkhede <ameynarkhede03@...il.com>
Cc:     "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: davinci: Drop pointer to mmc_host from mmc_davinci_host

On Thu, 24 Sep 2020 at 14:49, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
> On Sun, 20 Sep 2020 at 22:51, Amey Narkhede <ameynarkhede03@...il.com> wrote:
> >
> > The TI DaVinci MMC host driver uses a pointer to get from
> > the private mmc_davinci_host structure to generic mmc_host
> > structure. However mmc_host always immediately precedes
> > mmc_davinci_host in memory hence get the address of that
> > mmc_host structure using mmc_from_priv() which performs
> > subtraction(which is cheaper than a dereference) and drop
> > the unnecessary pointer.
> >
> > Signed-off-by: Amey Narkhede <ameynarkhede03@...il.com>
>
> Applied for next, thanks!

Turned out that this one did cause build errors, so I have dropped it
from my next branch.

Please re-spin a v2 and make sure to run a build test before you submit again.

[...]

Kind regards
Uffe