linux-kernel - Re: [PATCH] mmc: sdhci-s3c: hide forward declaration of of_device_id behind CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFo5B5j40W2wVi6rHsrHJscg_QeER2R7vaib3mE85yEuMA@mail.gmail.com>
Date:   Fri, 25 Sep 2020 13:31:35 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Ben Dooks <ben-linux@...ff.org>,
        Jaehoon Chung <jh80.chung@...sung.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Nathan Chancellor <natechancellor@...il.com>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        clang-built-linux@...glegroups.com
Subject: Re: [PATCH] mmc: sdhci-s3c: hide forward declaration of of_device_id
 behind CONFIG_OF

On Fri, 25 Sep 2020 at 09:26, Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> The struct of_device_id is not defined with !CONFIG_OF so its forward
> declaration should be hidden to as well.  This should address clang
> compile warning:
>
>   drivers/mmc/host/sdhci-s3c.c:464:34: warning: tentative array definition assumed to have one element
>
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/sdhci-s3c.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index cb5f87be7535..f48a788a9d3d 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -461,7 +461,9 @@ static int sdhci_s3c_parse_dt(struct device *dev,
>  }
>  #endif
>
> +#ifdef CONFIG_OF
>  static const struct of_device_id sdhci_s3c_dt_match[];
> +#endif
>
>  static inline struct sdhci_s3c_drv_data *sdhci_s3c_get_driver_data(
>                         struct platform_device *pdev)
> --
> 2.17.1
>