linux-kernel - Re: [PATCH] mm: remove unused early_pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <244583cb-6603-783b-b3c6-7a82e1bfa77d@redhat.com>
Date:   Fri, 25 Sep 2020 14:21:40 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Mike Rapoport <rppt@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Mike Rapoport <rppt@...ux.ibm.com>
Subject: Re: [PATCH] mm: remove unused early_pfn_valid()

On 23.09.20 18:29, Mike Rapoport wrote:
> From: Mike Rapoport <rppt@...ux.ibm.com>
> 
> The early_pfn_valid() macro is defined by it is never used.
> Remove it.
> 
> Signed-off-by: Mike Rapoport <rppt@...ux.ibm.com>
> ---
>  include/linux/mmzone.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 8379432f4f2f..38264363b0d4 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -1376,7 +1376,6 @@ static inline unsigned long next_present_section_nr(unsigned long section_nr)
>  #define pfn_to_nid(pfn)		(0)
>  #endif
>  
> -#define early_pfn_valid(pfn)	pfn_valid(pfn)
>  void sparse_init(void);
>  #else
>  #define sparse_init()	do {} while (0)
> @@ -1396,10 +1395,6 @@ struct mminit_pfnnid_cache {
>  	int last_nid;
>  };
>  
> -#ifndef early_pfn_valid
> -#define early_pfn_valid(pfn)	(1)
> -#endif
> -
>  /*
>   * If it is possible to have holes within a MAX_ORDER_NR_PAGES, then we
>   * need to check pfn validity within that MAX_ORDER_NR_PAGES block.
> 

Think the last user was removed with

commit 73a6e474cb376921a311786652782155eac2fdf0
Author: Baoquan He <bhe@...hat.com>
Date:   Wed Jun 3 15:57:55 2020 -0700

    mm: memmap_init: iterate over memblock regions rather that check
each PFN

    When called during boot the memmap_init_zone() function checks if
each PFN
    is valid and actually belongs to the node being initialized using
    early_pfn_valid() and early_pfn_in_nid().

Acked-by: David Hildenbrand <david@...hat.com>

-- 
Thanks,

David / dhildenb