linux-kernel - Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1601038258.15065.4.camel@mtkswgap22>
Date:   Fri, 25 Sep 2020 20:50:58 +0800
From:   Hanks Chen <hanks.chen@...iatek.com>
To:     Sean Wang <sean.wang@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        <linux-mediatek@...ts.infradead.org>, <linux-gpio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, CC Hwang <cc.hwang@...iatek.com>,
        sin_jieyang <sin_jieyang@...iatek.com>
Subject: Re: [PATCH v2] pinctrl: mediatek: check mtk_is_virt_gpio input
 parameter

Hi Sean & Linux & Matthias,

Please kindly let me know your comments about this fixes patch.
Thanks

Regards,
Hanks


On Thu, 2020-08-20 at 19:22 +0800, Hanks Chen wrote:
> check mtk_is_virt_gpio input parameter,
> virtual gpio need to support eint mode.
> 
> add error handler for the ko case
> to fix this boot fail:
> pc : mtk_is_virt_gpio+0x20/0x38 [pinctrl_mtk_common_v2]
> lr : mtk_gpio_get_direction+0x44/0xb0 [pinctrl_paris]
> 
> Fixes: edd546465002 ("pinctrl: mediatek: avoid virtual gpio trying to set reg")
> Singed-off-by: Jie Yang <sin_jieyang@...iatek.com>
> Signed-off-by: Hanks Chen <hanks.chen@...iatek.com>
> 
> ---
> Changes since v1:
> - update Singed-off-by
> - align with pinctrl/mediatek/pinctrl-mtk-mt*.h 
> 
> ---
>  drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index c53e2c391e32..a485d79f51a1 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -259,6 +259,10 @@ bool mtk_is_virt_gpio(struct mtk_pinctrl *hw, unsigned int gpio_n)
>  
>  	desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio_n];
>  
> +	/* if the GPIO is not supported for eint mode */
> +	if (desc->eint.eint_m == NO_EINT_SUPPORT)
> +		return virt_gpio;
> +
>  	if (desc->funcs && !desc->funcs[desc->eint.eint_m].name)
>  		virt_gpio = true;
>