linux-kernel - Re: [PATCH 3/5] perf tools: Copy metric events properly when expand cgroups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200925135133.GC3273770@krava>
Date:   Fri, 25 Sep 2020 15:51:33 +0200
From:   Jiri Olsa <jolsa@...hat.com>
To:     Namhyung Kim <namhyung@...nel.org>
Cc:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <a.p.zijlstra@...llo.nl>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Stephane Eranian <eranian@...gle.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Ian Rogers <irogers@...gle.com>,
        John Garry <john.garry@...wei.com>,
        Kajol Jain <kjain@...ux.ibm.com>,
        kernel test robot <rong.a.chen@...el.com>
Subject: Re: [PATCH 3/5] perf tools: Copy metric events properly when expand
 cgroups

On Fri, Sep 25, 2020 at 10:44:53PM +0900, Namhyung Kim wrote:
> On Fri, Sep 25, 2020 at 10:26 PM Jiri Olsa <jolsa@...hat.com> wrote:
> >
> > On Thu, Sep 24, 2020 at 09:44:53PM +0900, Namhyung Kim wrote:
> >
> > SNIP
> >
> > >
> > > +     if (metric_events) {
> > > +             orig_metric_events = *metric_events;
> > > +             rblist__init(metric_events);
> > > +     } else {
> > > +             rblist__init(&orig_metric_events);
> > > +     }
> > > +
> > >       for (;;) {
> > >               p = strchr(str, ',');
> > >               e = p ? p : eos;
> > > @@ -255,6 +267,14 @@ int evlist__expand_cgroup(struct evlist *evlist, const char *str)
> > >               cgroup__put(cgrp);
> > >               nr_cgroups++;
> > >
> > > +             if (metric_events) {
> > > +                     perf_stat__collect_metric_expr(tmp_list);
> > > +                     if (metricgroup__copy_metric_events(tmp_list, cgrp,
> > > +                                                         metric_events,
> > > +                                                         &orig_metric_events) < 0)
> > > +                             break;
> > > +             }
> >
> > looks good, do you plan to actualy add support for record?
> 
> No actually, I still think perf record should use --all-cgroups.
> 
> > my ack from last version stays
> 
> Thanks!  But I didn't see your ack for this patch set.
> (I've only seen it for the perf inject patchset..)

ah that was for the build id inject speed up.. too many
patchsets flying around ;-)

Acked-by: Jiri Olsa <jolsa@...hat.com>

thanks,
jirka