linux-kernel - Re: [PATCH 1/5] misc: vop: change the way of allocating vring for noncoherent platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200926075015.GA18592@infradead.org>
Date:   Sat, 26 Sep 2020 08:50:15 +0100
From:   Christoph Hellwig <hch@...radead.org>
To:     Sherry Sun <sherry.sun@....com>
Cc:     sudeep.dutt@...el.com, ashutosh.dixit@...el.com, arnd@...db.de,
        gregkh@...uxfoundation.org, wang.yi59@....com.cn,
        huang.zijiang@....com.cn, rikard.falkeborn@...il.com,
        lee.jones@...aro.org, mst@...hat.com, linux-kernel@...r.kernel.org,
        linux-imx@....com
Subject: Re: [PATCH 1/5] misc: vop: change the way of allocating vring for
 noncoherent platform

> +#include <linux/dma-noncoherent.h>

This header must not be included in drivers.

>  
> +		if (dev_is_dma_coherent(vop_dev(vdev)))

And this API must not be used in drivers either.

> +			vdev->vvr[i].vrh.vring.used =
> +				(void __force *)vpdev->hw_ops->remap(

And you must not use __force casts without a comment explanation why
they are safe.