linux-kernel - Re: [PATCH -next] s390/3215: simplify the return expression of tty3215

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 26 Sep 2020 14:46:50 +0200
From:   Vasily Gorbik <gor@...ux.ibm.com>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Heiko Carstens <hca@...ux.ibm.com>,
        Christian Borntraeger <borntraeger@...ibm.com>,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] s390/3215: simplify the return expression of
 tty3215_open()

On Mon, Sep 21, 2020 at 09:11:01PM +0800, Qinglang Miao wrote:
> Simplify the return expression.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  drivers/s390/char/con3215.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index 92757f9bd..d8acabbb1 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -978,7 +978,6 @@ static int tty3215_install(struct tty_driver *driver, struct tty_struct *tty)
>  static int tty3215_open(struct tty_struct *tty, struct file * filp)
>  {
>  	struct raw3215_info *raw = tty->driver_data;
> -	int retval;
>  
>  	tty_port_tty_set(&raw->port, tty);
>  
> @@ -986,11 +985,7 @@ static int tty3215_open(struct tty_struct *tty, struct file * filp)
>  	/*
>  	 * Start up 3215 device
>  	 */
> -	retval = raw3215_startup(raw);
> -	if (retval)
> -		return retval;
> -
> -	return 0;
> +	return raw3215_startup(raw);
>  }

Applied, thank you.