linux-kernel - Re: [PATCH leds v2 00/50] Start moving parsing of `linux,default-trigger` to LED core (a cleanup of LED drivers)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200926134706.GJ4828@kw.sim.vm.gnt>
Date:   Sat, 26 Sep 2020 15:47:06 +0200
From:   Simon Guinot <simon.guinot@...uanux.org>
To:     Marek Behún <marek.behun@....cz>
Cc:     linux-leds@...r.kernel.org, Pavel Machek <pavel@....cz>,
        Dan Murphy <dmurphy@...com>,
        Ondřej Jirman <megous@...ous.com>,
        linux-kernel@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        devicetree@...r.kernel.org,
        Álvaro Fernández Rojas <noltari@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Andrey Utkin <andrey_utkin@...tmail.com>,
        Baolin Wang <baolin.wang7@...il.com>,
        Baolin Wang <baolin.wang@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Christian Mauderer <oss@...auderer.de>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        Daniel Mack <daniel@...aq.de>,
        David Rivshin <drivshin@...worx.com>,
        Grant Feng <von81@....com>,
        Haojian Zhuang <haojian.zhuang@...vell.com>,
        "H . Nikolaus Schaller" <hns@...delico.com>,
        Jaedon Shin <jaedon.shin@...il.com>,
        John Crispin <john@...ozen.org>,
        Kevin Cernekee <cernekee@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Mark Brown <broonie@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Michael Ellerman <mpe@...erman.id.au>,
        Milo Kim <milo.kim@...com>, NeilBrown <neilb@...e.de>,
        Nikita Travkin <nikitos.tr@...il.com>,
        Orson Zhai <orsonzhai@...il.com>,
        Paul Mackerras <paulus@...ba.org>,
        Philippe Retornaz <philippe.retornaz@...l.ch>,
        Riku Voipio <riku.voipio@....fi>,
        Rod Whitby <rod@...tby.id.au>,
        Ryder Lee <ryder.lee@...iatek.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Sebastian Reichel <sre@...nel.org>,
        Simon Guinot <sguinot@...ie.com>,
        Simon Shields <simon@...eageos.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Thomas Bogendoerfer <tbogendoerfer@...e.de>,
        Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Vasant Hegde <hegdevasant@...ux.vnet.ibm.com>,
        Vincent Donnefort <vdonnefort@...il.com>,
        Xiaotong Lu <xiaotong.lu@...eadtrum.com>
Subject: Re: [PATCH leds v2 00/50] Start moving parsing of
 `linux,default-trigger` to LED core (a cleanup of LED drivers)

On Fri, Sep 18, 2020 at 12:32:48AM +0200, Marek Behún wrote:
> Hi,
> 
> this series is also available at [1].
> 
> This is v2, you can read cover letter of v1 at [2] (togehter with
> explanation of why I did this).
> 
> Changes since v1:
> - split big changes into several patches of little changes
> - added many cosmetic fixes (helper variables, reversal christmas tree
>   variables declaration, ...)
> - fixed some bugs in various drivers (memory leaks, iteration over
>   unavailable OF nodes)
> - made some drivers compilable when COMPILE_TEST=y (since allyesconfig
>   did not compile them). Not all though, some still don't compile with
>   allyesconfig
> - the commit that moves parsing of `linux,default-trigger` property from
>   drivers to LED core is now last in the series, instead of first
> 
> Marek
> 
> [1] https://git.kernel.org/pub/scm/linux/kernel/git/kabel/linux.git/log/?h=leds-cleanup-for-pavel
> [2] https://lore.kernel.org/linux-leds/20200916231650.11484-1-marek.behun@nic.cz/T/#m826493318174b0f38a3d4ba107092b5420ce440c

...

>   leds: ns2: use devres LED registering function
>   leds: ns2: alloc simple array instead of struct ns2_led_priv
>   leds: ns2: support OF probing only, forget platdata
>   leds: ns2: move parsing of one LED into separate function
>   leds: ns2: use devres API for getting GPIO descriptors
>   leds: ns2: cosmetic structure rename
>   leds: ns2: cosmetic variable rename
>   leds: ns2: cosmetic change
>   leds: ns2: cosmetic change: use helper variable
>   leds: ns2: register LED immediately after parsing DT properties
>   leds: ns2: remove unneeded variable
>   leds: ns2: cosmetic: use reverse christmas tree
>   leds: ns2: reorder headers alphabetically
>   leds: ns2: use struct led_init_data when registering
>   leds: parse linux,default-trigger DT property in LED core

Hi Marek,

For all the patches applying to the leds-ns2 driver:

Reviewed-by: Simon Guinot <simon.guinot@...uanux.org>
Tested-by: Simon Guinot <simon.guinot@...uanux.org>

Thanks for it. The driver is looking way better.

Simon

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)