linux-kernel - Re: [PATCH v3 4/4] dt-bindings: iio: ad9467: add entries for for AD9434 & AD9265 ADCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200926160311.1c9a0444@archlinux>
Date:   Sat, 26 Sep 2020 16:03:11 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <robh+dt@...nel.org>,
        <Michael.Hennerich@...log.com>
Subject: Re: [PATCH v3 4/4] dt-bindings: iio: ad9467: add entries for for
 AD9434 & AD9265 ADCs

On Thu, 24 Sep 2020 11:05:18 +0300
Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:

> Add entries for the AD9434 & AD9265 high-speed ADCs which are supported by
> the 'ad9467' driver.
> Better describe the family of ADCs similar to AD9467 in the description.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
As this is just an ID and a bit of descriptive text, I'm not going to
waste Rob's time by expecting him to take a look!
@Rob: Of course you are welcome to take a look if you like.

I've tweaked the description a tiny bit as below.

Series applied to the togreg branch of iio.git and pushed out as testing
for all the normal reasons (autobuilders etc).

Thanks,

Jonathan

> ---
>  .../devicetree/bindings/iio/adc/adi,ad9467.yaml   | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> index c4f57fa6aad1..579dbc63e3fe 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad9467.yaml
> @@ -4,21 +4,30 @@
>  $id: http://devicetree.org/schemas/iio/adc/adi,ad9467.yaml#
>  $schema: http://devicetree.org/meta-schemas/core.yaml#
>  
> -title: Analog Devices AD9467 High-Speed ADC
> +title: Analog Devices AD9467 and similar High-Speed ADCs
>  
>  maintainers:
>    - Michael Hennerich <michael.hennerich@...log.com>
>    - Alexandru Ardelean <alexandru.ardelean@...log.com>
>  
>  description: |
> -  The AD9467 is a 16-bit, monolithic, IF sampling analog-to-digital
> -  converter (ADC).
> +  The AD9467 and the parts similar with it, are high-speed analog-to-digital
> +  converters (ADCs), operating in the range of 100 to 500 mega samples
> +  per second (MSPS). Depending on the part, some support higher MSPS and some
> +  lower MSPS, depending on the application each part is intended for.
The Depending.... depending is a bit awkward so I'll rephrase that as

Some parts support higher MSPS and some lower MSPS, suitable for the
intended application of each part.

>  
> +  All the parts support the register map described by Application Note AN-877
> +   https://www.analog.com/media/en/technical-documentation/application-notes/AN-877.pdf
> +
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/AD9265.pdf
> +  https://www.analog.com/media/en/technical-documentation/data-sheets/AD9434.pdf
>    https://www.analog.com/media/en/technical-documentation/data-sheets/AD9467.pdf
>  
>  properties:
>    compatible:
>      enum:
> +      - adi,ad9265
> +      - adi,ad9434
>        - adi,ad9467
>  
>    reg: