linux-kernel - Re: [RESEND PATCH v2] iio: adc: stm32-adc: fix runtime autosuspend delay when slow polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200926161732.72af96e3@archlinux>
Date:   Sat, 26 Sep 2020 16:17:32 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Fabrice Gasnier <fabrice.gasnier@...com>
Cc:     <rafael.j.wysocki@...el.com>, <rjw@...ysocki.net>,
        <ulf.hansson@...aro.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <mcoquelin.stm32@...il.com>,
        <alexandre.torgue@...com>, <olivier.moysan@...com>,
        <linux-iio@...r.kernel.org>,
        <linux-stm32@...md-mailman.stormreply.com>
Subject: Re: [RESEND PATCH v2] iio: adc: stm32-adc: fix runtime autosuspend
 delay when slow polling

On Wed, 16 Sep 2020 12:28:00 +0200
Fabrice Gasnier <fabrice.gasnier@...com> wrote:

> On 7/1/20 4:55 PM, Fabrice Gasnier wrote:
> > When the ADC is runtime suspended and starting a conversion, the stm32-adc
> > driver calls pm_runtime_get_sync() that gets cascaded to the parent
> > (e.g. runtime resume of stm32-adc-core driver). This also kicks the
> > autosuspend delay (e.g. 2s) of the parent.
> > Once the ADC is active, calling pm_runtime_get_sync() again (upon a new
> > capture) won't kick the autosuspend delay for the parent (stm32-adc-core
> > driver) as already active.
> > 
> > Currently, this makes the stm32-adc-core driver go in suspend state
> > every 2s when doing slow polling. As an example, doing a capture, e.g.
> > cat in_voltageY_raw at a 0.2s rate, the auto suspend delay for the parent
> > isn't refreshed. Once it expires, the parent immediately falls into
> > runtime suspended state, in between two captures, as soon as the child
> > driver falls into runtime suspend state:
> > - e.g. after 2s, + child calls pm_runtime_put_autosuspend() + 100ms
> >   autosuspend delay of the child.
> > - stm32-adc-core switches off regulators, clocks and so on.
> > - They get switched on back again 100ms later in this example (at 2.2s).
> > 
> > So, use runtime_idle() callback in stm32-adc-core driver to call
> > pm_runtime_mark_last_busy() for the parent driver (stm32-adc-core),
> > to avoid this.
> > 
> > Fixes: 9bdbb1139ca1 ("iio: adc: stm32-adc: add power management support")
> > 
> > Signed-off-by: Fabrice Gasnier <fabrice.gasnier@...com>
> > ---
> > Changes in v2:
> > - Use runtime_idle callback in stm32-adc-core driver, instead of refreshing
> >   last_busy from the child (for the parent) at many place. Initial patch v1
> >   looked like "somewhat adhoc solution" as commented by Jonathan.  
> 
> Hi all,
> 
> Gentle reminder for this patch. Earlier discussions on it were as per
> [1] and [2].
> 
> Ideally, Jonathan was looking for an ack from Rafael on this patch.
> This is a long pending issue. I'd like to progress on this.
> 
> [1] https://patchwork.kernel.org/patch/11349841/
> [2] https://lkml.org/lkml/2020/6/11/279

Fabrice, I think this one has sat waiting for inputs for
too long. Hence I'm going to take a slight gamble that you are correct
on doing the fix this way (I'm reasonably convinced)

Applied to the fixes-togreg branch of iio.git.
It won't go in for 5.9 now, so we have a bit of time for any last
minute comments.

Thanks,

Jonathan

> 
> Please advise,
> Thanks in advance,
> Fabrice
> 
> > ---
> >  drivers/iio/adc/stm32-adc-core.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c
> > index 0e2068e..3586369 100644
> > --- a/drivers/iio/adc/stm32-adc-core.c
> > +++ b/drivers/iio/adc/stm32-adc-core.c
> > @@ -794,6 +794,13 @@ static int stm32_adc_core_runtime_resume(struct device *dev)
> >  {
> >  	return stm32_adc_core_hw_start(dev);
> >  }
> > +
> > +static int stm32_adc_core_runtime_idle(struct device *dev)
> > +{
> > +	pm_runtime_mark_last_busy(dev);
> > +
> > +	return 0;
> > +}
> >  #endif
> >  
> >  static const struct dev_pm_ops stm32_adc_core_pm_ops = {
> > @@ -801,7 +808,7 @@ static const struct dev_pm_ops stm32_adc_core_pm_ops = {
> >  				pm_runtime_force_resume)
> >  	SET_RUNTIME_PM_OPS(stm32_adc_core_runtime_suspend,
> >  			   stm32_adc_core_runtime_resume,
> > -			   NULL)
> > +			   stm32_adc_core_runtime_idle)
> >  };
> >  
> >  static const struct stm32_adc_priv_cfg stm32f4_adc_priv_cfg = {
> >