lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Sep 2020 00:37:56 +0300 From: Dmitry Osipenko <digetx@...il.com> To: Nicolin Chen <nicoleotsuka@...il.com>, thierry.reding@...il.com, joro@...tes.org, krzk@...nel.org Cc: linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org, iommu@...ts.linux-foundation.org, jonathanh@...dia.com Subject: Re: [PATCH 5/5] iommu/tegra-smmu: Add pagetable mappings to debugfs 27.09.2020 00:24, Dmitry Osipenko пишет: > 26.09.2020 11:07, Nicolin Chen пишет: > ... >> + for (pd_index = 0; pd_index < SMMU_NUM_PDE; pd_index++) { >> + struct page *pt; >> + u32 *addr; >> + >> + if (!as->count[pd_index] || !pd[pd_index]) >> + continue; > > I guess the idea of this patch is to print out the hardware state, isn't > it? Hence the as->count shouldn't be checked here. Perhaps also will be good to check whether the state of !as->count[pd_index] matches state of !pd[pd_index]. WARN_ON_ONCE(!as->count[pd_index] ^ !pd[pd_index])
Powered by blists - more mailing lists