linux-kernel - Re: [PATCH] Documentation/llvm: Fix clang target examples

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200926021146.GA1917299@ubuntu-n2-xlarge-x86>
Date:   Fri, 25 Sep 2020 19:11:46 -0700
From:   Nathan Chancellor <natechancellor@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Jonathan Corbet <corbet@....net>,
        Kees Cook <keescook@...omium.org>,
        Sedat Dilek <sedat.dilek@...il.com>,
        "open list:CLANG/LLVM BUILD SUPPORT" 
        <clang-built-linux@...glegroups.com>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH] Documentation/llvm: Fix clang target examples

On Fri, Sep 25, 2020 at 08:21:14AM -0700, Florian Fainelli wrote:
> clang --target=<triple> is how we can specify a particular toolchain
> triple to be use, fix the two occurences in the documentation.
> 
> Fixes: fcf1b6a35c16 ("Documentation/llvm: add documentation on building w/ Clang/LLVM")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Reviewed-by: Nathan Chancellor <natechancellor@...il.com>

Thank you for the patch!

> ---
>  Documentation/kbuild/llvm.rst | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/kbuild/llvm.rst b/Documentation/kbuild/llvm.rst
> index 334df758dce3..dae90c21aed3 100644
> --- a/Documentation/kbuild/llvm.rst
> +++ b/Documentation/kbuild/llvm.rst
> @@ -39,10 +39,10 @@ which can help simplify cross compiling. ::
>  	ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- make CC=clang
>  
>  ``CROSS_COMPILE`` is not used to prefix the Clang compiler binary, instead
> -``CROSS_COMPILE`` is used to set a command line flag: ``--target <triple>``. For
> +``CROSS_COMPILE`` is used to set a command line flag: ``--target=<triple>``. For
>  example: ::
>  
> -	clang --target aarch64-linux-gnu foo.c
> +	clang --target=aarch64-linux-gnu foo.c
>  
>  LLVM Utilities
>  --------------
> -- 
> 2.25.1
>