linux-kernel - Re: [PATCH] MIPS: irq: Add missing prototypes for init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 27 Sep 2020 11:08:30 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Pujin Shi <shipujin.t@...il.com>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: irq: Add missing prototypes for init_IRQ()

On Wed, Sep 23, 2020 at 11:26:50AM +0800, Pujin Shi wrote:
> init_IRQ() have no prototype, add one in irq.h
> 
> Fix the following warnings (treated as error in W=1):
> arch/mips/kernel/irq.c:52:13: error: no previous prototype for 'init_IRQ' [-Werror=missing-prototypes]
> 
> Signed-off-by: Pujin Shi <shipujin.t@...il.com>
> ---
>  arch/mips/include/asm/irq.h | 1 +
>  arch/mips/kernel/irq.c      | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/mips/include/asm/irq.h b/arch/mips/include/asm/irq.h
> index c5d351786416..992f8040d3d9 100644
> --- a/arch/mips/include/asm/irq.h
> +++ b/arch/mips/include/asm/irq.h
> @@ -21,6 +21,7 @@
>  #define IRQ_STACK_START			(IRQ_STACK_SIZE - 16)
>  
>  extern void *irq_stack[NR_CPUS];
> +void init_IRQ(void);

putting it here hasn't any value. If you want to fix this properly,
move the extern void init_IRQ(void) in init/main.c to a common header
file and check that every arch to uses it.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]