linux-kernel - Re: [PATCH 0/3] Add support for F3A

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05140fb1-19a5-d740-2c57-e39e450142ec@redhat.com>
Date:   Sun, 27 Sep 2020 13:12:47 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Vincent Huang <vincent.huang@...synaptics.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Jiri Kosina <jikos@...nel.org>,
        Andrew Duggan <aduggan@...aptics.com>,
        Benjamin Tissoires <btissoir@...hat.com>,
        Lyude Paul <lyude@...hat.com>,
        Chris Heiny <chris.heiny@...aptics.com>
Subject: Re: [PATCH 0/3] Add support for F3A

Hi,

On 9/24/20 11:46 AM, Vincent Huang wrote:
> RMI4 F3A supports the touchpad GPIO function, it's designed to support
> more GPIOs and used on newer touchpads. The patches add support of
> touchpad buttons and rename f30_data to avoid confusion.

Thank you for the patch. So as already mentioned patches 1 and 2
need to be combined into a single patch.

Otherwise the patches look good to me and I can confirm that
they fix clickpad clicks not registering when using rmi4 for the touchpad
on the Lenovo T14 gen 1.

So for version 2 (with patches 1 and 2 combined into a single patch)
you may add my:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>
Tested-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans

> 
> Vincent Huang (3):
>    Input: synaptics-rmi4 - rename f30_data to gpio_data
>    HID: rmi - rename f30_data to gpio_data
>    Input: synaptics-rmi4 - add support for F3A
> 
>   drivers/hid/hid-rmi.c           |   2 +-
>   drivers/input/mouse/synaptics.c |   2 +-
>   drivers/input/rmi4/Kconfig      |   8 ++
>   drivers/input/rmi4/Makefile     |   1 +
>   drivers/input/rmi4/rmi_bus.c    |   3 +
>   drivers/input/rmi4/rmi_driver.h |   1 +
>   drivers/input/rmi4/rmi_f30.c    |  14 +-
>   drivers/input/rmi4/rmi_f3a.c    | 241 ++++++++++++++++++++++++++++++++
>   include/linux/rmi.h             |  11 +-
>   9 files changed, 269 insertions(+), 14 deletions(-)
>   create mode 100644 drivers/input/rmi4/rmi_f3a.c
>