linux-kernel - RE: [PATCH 1/3] mic: vop: fix a written error in MODULE_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB4960185041AEE411141583EA92340@VI1PR04MB4960.eurprd04.prod.outlook.com>
Date:   Sun, 27 Sep 2020 12:19:50 +0000
From:   Sherry Sun <sherry.sun@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "sudeep.dutt@...el.com" <sudeep.dutt@...el.com>,
        "ashutosh.dixit@...el.com" <ashutosh.dixit@...el.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "michal.lkml@...kovi.net" <michal.lkml@...kovi.net>,
        "lee.jones@...aro.org" <lee.jones@...aro.org>,
        "rikard.falkeborn@...il.com" <rikard.falkeborn@...il.com>,
        "mst@...hat.co" <mst@...hat.co>, "bp@...e.de" <bp@...e.de>,
        "jhugo@...eaurora.org" <jhugo@...eaurora.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
        "mgross@...ux.intel.com" <mgross@...ux.intel.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>, Sherry Sun <sherry.sun@....com>
Subject: RE: [PATCH 1/3] mic: vop: fix a written error in MODULE_DEVICE_TABLE

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: 2020年9月27日 18:29
> To: Sherry Sun <sherry.sun@....com>
> Cc: sudeep.dutt@...el.com; ashutosh.dixit@...el.com; arnd@...db.de;
> masahiroy@...nel.org; michal.lkml@...kovi.net; lee.jones@...aro.org;
> rikard.falkeborn@...il.com; mst@...hat.co; bp@...e.de;
> jhugo@...eaurora.org; tglx@...utronix.de;
> manivannan.sadhasivam@...aro.org; mgross@...ux.intel.com; pierre-
> louis.bossart@...ux.intel.com; linux-kernel@...r.kernel.org; linux-
> kbuild@...r.kernel.org; dl-linux-imx <linux-imx@....com>
> Subject: Re: [PATCH 1/3] mic: vop: fix a written error in
> MODULE_DEVICE_TABLE
> 
> On Fri, Sep 25, 2020 at 03:31:56PM +0800, Sherry Sun wrote:
> > For vop bus, the first parameter should be vop in MODULE_DEVICE_TABLE.
> >
> > Signed-off-by: Sherry Sun <sherry.sun@....com>
> > Signed-off-by: Joakim Zhang <qiangqing.zhang@....com>
> > ---
> >  drivers/misc/mic/vop/vop_main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/misc/mic/vop/vop_main.c
> > b/drivers/misc/mic/vop/vop_main.c index d609f0dc6124..589425fa78d4
> > 100644
> > --- a/drivers/misc/mic/vop/vop_main.c
> > +++ b/drivers/misc/mic/vop/vop_main.c
> > @@ -796,7 +796,7 @@ static struct vop_driver vop_driver = {
> >
> >  module_vop_driver(vop_driver);
> >
> > -MODULE_DEVICE_TABLE(mbus, id_table);
> > +MODULE_DEVICE_TABLE(vop, id_table);
> >  MODULE_AUTHOR("Intel Corporation");
> >  MODULE_DESCRIPTION("Intel(R) Virtio Over PCIe (VOP) driver");
> > MODULE_LICENSE("GPL v2");
> 
> Doesn't this have to go _after_ the MODULE_DEVICE_TABLE(vop...) support,
> which you add in patch 2 of this series?

Yes, this patch must be used in conjunction with Patch2.
But I think here may be a small bug, in order to distinguish it from the driver
autoloading support, make this a separate patch.

I can put this patch together with Patch2 if you think it might look more reasonable.

> 
> Does this patch here break the build?  If not, how is it working?
> 
> And if you only have one vop driver, why do you need autoloading for it?
> 
No, it doesn't break the build. But actually it won't work(autoloaded) when kernel boot and vop device appears.

Although we may only have one vop driver, but in the mic Kconfig, the intel mic/vop/cosm/scif drivers all
recommended to be built as modules, if we don't add autoloading for them, we may need modprobe them
one by one manually both on EP and RC side.

Obviously, for our use case, driver autoloading is more convenient.

Best regards
Sherry

> thanks,
> 
> greg k-h