[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <77c83c45-4087-eab8-ee66-6bcca11a5e2d@infradead.org>
Date: Sun, 27 Sep 2020 09:14:29 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Yangbo Lu <yangbo.lu@....com>, netdev@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
"David S . Miller" <davem@...emloft.net>,
Richard Cochran <richardcochran@...il.com>,
Kurt Kanzenbach <kurt@...utronix.de>,
Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] ptp: add stub function for ptp_get_msgtype()
On 9/27/20 1:01 AM, Yangbo Lu wrote:
> Added the missing stub function for ptp_get_msgtype().
>
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Fixes: 036c508ba95e ("ptp: Add generic ptp message type function")
> Signed-off-by: Yangbo Lu <yangbo.lu@....com>
Yes, that works. Thanks.
Acked-by: Randy Dunlap <rdunlap@...radead.org> # build-tested
> ---
> include/linux/ptp_classify.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/include/linux/ptp_classify.h b/include/linux/ptp_classify.h
> index 8437307..c6487b7 100644
> --- a/include/linux/ptp_classify.h
> +++ b/include/linux/ptp_classify.h
> @@ -134,5 +134,13 @@ static inline struct ptp_header *ptp_parse_header(struct sk_buff *skb,
> {
> return NULL;
> }
> +static inline u8 ptp_get_msgtype(const struct ptp_header *hdr,
> + unsigned int type)
> +{
> + /* The return is meaningless. The stub function would not be
> + * executed since no available header from ptp_parse_header.
> + */
> + return 0;
> +}
> #endif
> #endif /* _PTP_CLASSIFY_H_ */
>
--
~Randy
Powered by blists - more mailing lists