[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGp9Lzo0R=7diO62sWwfKFTn7WZFnFbE2aQDV8Yh8UZ4=bm8mA@mail.gmail.com>
Date: Sun, 27 Sep 2020 11:39:03 -0700
From: Sean Wang <sean.wang@...nel.org>
To: Qinglang Miao <miaoqinglang@...wei.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Matthias Brugger <matthias.bgg@...il.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@...ts.infradead.org>,
"open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] pinctrl: mediatek: simplify the return expression
of mtk_pinconf_bias_disable_set_rev1()
On Mon, Sep 21, 2020 at 6:10 AM Qinglang Miao <miaoqinglang@...wei.com> wrote:
>
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
Acked-by: Sean Wang <sean.wang@...nel.org>
> ---
> drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> index 2f3dfb56c..16bb15226 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
> @@ -479,14 +479,8 @@ EXPORT_SYMBOL_GPL(mtk_pinconf_bias_get);
> int mtk_pinconf_bias_disable_set_rev1(struct mtk_pinctrl *hw,
> const struct mtk_pin_desc *desc)
> {
> - int err;
> -
> - err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_PULLEN,
> - MTK_DISABLE);
> - if (err)
> - return err;
> -
> - return 0;
> + return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_PULLEN,
> + MTK_DISABLE);
> }
> EXPORT_SYMBOL_GPL(mtk_pinconf_bias_disable_set_rev1);
>
> --
> 2.23.0
>
Powered by blists - more mailing lists