linux-kernel - Re: [PATCH 12/18] ACPI: use semicolons rather than commas to separate statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <446ee567-ecc1-fcc9-2691-d4160fdf2150@wanadoo.fr>
Date:   Sun, 27 Sep 2020 22:27:41 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Julia Lawall <Julia.Lawall@...ia.fr>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Valdis Klētnieks <valdis.kletnieks@...edu>,
        Joe Perches <joe@...ches.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        kernel-janitors@...r.kernel.org, Len Brown <lenb@...nel.org>,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 12/18] ACPI: use semicolons rather than commas to separate
 statements

Le 27/09/2020 à 21:12, Julia Lawall a écrit :
> Replace commas with semicolons.  What is done is essentially described by
> the following Coccinelle semantic patch (http://coccinelle.lip6.fr/):
> 
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>
> 
> ---
>   drivers/acpi/processor_idle.c |    4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c
> index f66236cff69b..85502143f506 100644
> --- a/drivers/acpi/processor_idle.c
> +++ b/drivers/acpi/processor_idle.c
> @@ -1077,7 +1077,9 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr)
>   		/* flatten all the LPI states in this level of hierarchy */
>   		flatten_lpi_states(pr, curr, prev);
>   
> -		tmp = prev, prev = curr, curr = tmp;
> +		tmp = prev;
> +		prev = curr;
> +		curr = tmp;
>   
>   		status = acpi_get_parent(handle, &pr_ahandle);
>   	}
> 
> 
swap(prev, curr)?

CJ