lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Sep 2020 02:37:00 +0300 From: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com> To: Borislav Petkov <bp@...en8.de> Cc: x86@...nel.org, linux-sgx@...r.kernel.org, linux-kernel@...r.kernel.org, Sean Christopherson <sean.j.christopherson@...el.com>, Andy Lutomirski <luto@...capital.net>, Jethro Beekman <jethro@...tanix.com>, Cedric Xing <cedric.xing@...el.com>, akpm@...ux-foundation.org, andriy.shevchenko@...ux.intel.com, asapek@...gle.com, chenalexchen@...gle.com, conradparker@...gle.com, cyhanish@...gle.com, dave.hansen@...el.com, haitao.huang@...el.com, josh@...htriplett.org, kai.huang@...el.com, kai.svahn@...el.com, kmoy@...gle.com, ludloff@...gle.com, luto@...nel.org, nhorman@...hat.com, npmccallum@...hat.com, puiterwijk@...hat.com, rientjes@...gle.com, tglx@...utronix.de, yaozhangx@...gle.com Subject: Re: [PATCH v38 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call On Fri, Sep 25, 2020 at 10:28:07AM +0200, Borislav Petkov wrote: > > > I can see why you would write "TCS" though - there's a thread control > > > structure thing too in that patch. > > > > Renamed. > > See Sean's reply. I did not get Sean's reply, and neither can find it from lore: https://lore.kernel.org/linux-sgx/20200915112842.897265-1-jarkko.sakkinen@linux.intel.com/T/#t > > * typedef sgx_enclave_exit_handler_t - Exit handler function accepted by > > * __vdso_sgx_enter_enclave() > > * @rdi: RDI snapshot > > * @rsi: RSI snapshot > > * @rdx: RDX snapshot > > * @rsp: RSP snapshot (untrusted stack) > > * @r8: R8 snapshot > > * @r9: R9 snapshot > > I'd say here: > > "The registers' content is the snapshot made at enclave exit." I'd make that a description and take away individual parameter descriptions. Is that fine? > > Also, I renamed 'r' as 'run' in some places. > > > > End result: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-sgx.git/tree/arch/x86/include/uapi/asm/sgx.h > > > > I'm wondering this sentence: > > > > "The calling convention is custom and does not follow System V x86-64 ABI." > > Yeah, I was wondering what that meant too. I'll refine that one based on my own and Jethro's feedback. > -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette /Jarkko
Powered by blists - more mailing lists