linux-kernel - Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Sep 2020 20:15:29 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     "Surendrakumar Upadhyay\, TejaskumarX" 
        <tejaskumarx.surendrakumar.upadhyay@...el.com>,
        "Vivi\, Rodrigo" <rodrigo.vivi@...el.com>,
        "airlied\@linux.ie" <airlied@...ux.ie>,
        "daniel\@ffwll.ch" <daniel@...ll.ch>,
        "intel-gfx\@lists.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
        "dri-devel\@lists.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "Ausmus\, James" <james.ausmus@...el.com>,
        "Roper\, Matthew D" <matthew.d.roper@...el.com>,
        "Souza\, Jose" <jose.souza@...el.com>,
        "ville.syrjala\@linux.intel.com" <ville.syrjala@...ux.intel.com>,
        "De Marchi\, Lucas" <lucas.demarchi@...el.com>,
        "Pandey\, Hariom" <hariom.pandey@...el.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp/jsl: Update vswing table for HBR and HBR2

On Mon, 28 Sep 2020, "Surendrakumar Upadhyay, TejaskumarX"	<tejaskumarx.surendrakumar.upadhyay@...el.com> wrote:
> This is a good example of a potential trap that having
> IS_ELKHARTLAKE() cover both ELK and JSP creates. An unsuspecting coder
> might change the if ladder to have IS_ELKHARTLAKE() first, and the
> subsequent IS_JASPERLAKE() branch would never be taken.
>
> BR,
> Jani.
>
> Tejas : In that case I will put attention note in comment about
> platform checks such that ladder distrubance can be avoided. What you
> suggest?

The solution is to make IS_ELKHARTLAKE() mean ELK and only ELK.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center