linux-kernel - Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d6da2246-cf82-315e-c716-62ab9ec13a22@linux.intel.com>
Date:   Mon, 28 Sep 2020 11:32:19 -0700
From:   "Kuppuswamy, Sathyanarayanan" 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>
To:     Sinan Kaya <okaya@...nel.org>, Bjorn Helgaas <helgaas@...nel.org>
Cc:     bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org, ashok.raj@...el.com,
        Jay Vosburgh <jay.vosburgh@...onical.com>
Subject: Re: [PATCH v3 1/1] PCI/ERR: Fix reset logic in pcie_do_recovery()
 call



On 9/28/20 11:25 AM, Sinan Kaya wrote:
> On 9/28/2020 2:02 PM, Sinan Kaya wrote:
>> Since there is no state restoration for FATAL errors, I am wondering
>> whether
>> calls to ->error_detected(), ->mmio_enabled() and ->slot_reset() are
>> required?
> 
> I also would like to ask someone closer to the spec language double
> check this.
> 
> When we recover the link at the end of the DPC handler, what is the
> expected state of the endpoint?
> 
> Is it a some kind of a reset like secondary bus reset? (I assumed this
>   one)
I think it will be in reset state.
> 
> Undefined?
> 
> or just plain link recovery with everything else as intact as it used
> to be?
> 

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer