linux-kernel - Re: [PATCH v12 0/6] IOMMU user API enhancement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200928114053.79170d23@jacob-builder>
Date:   Mon, 28 Sep 2020 11:40:53 -0700
From:   Jacob Pan <jacob.jun.pan@...ux.intel.com>
To:     Jacob Pan <jacob.pan.linux@...il.com>
Cc:     iommu@...ts.linux-foundation.org,
        LKML <linux-kernel@...r.kernel.org>,
        Joerg Roedel <joro@...tes.org>,
        Alex Williamson <alex.williamson@...hat.com>,
        "Lu Baolu" <baolu.lu@...ux.intel.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Jonathan Corbet <corbet@....net>, linux-api@...r.kernel.org,
        Jean-Philippe Brucker <jean-philippe@...aro.com>,
        Eric Auger <eric.auger@...hat.com>,
        Yi Liu <yi.l.liu@...el.com>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        Raj Ashok <ashok.raj@...el.com>, Wu Hao <hao.wu@...el.com>,
        Yi Sun <yi.y.sun@...el.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        jacob.jun.pan@...ux.intel.com
Subject: Re: [PATCH v12 0/6] IOMMU user API enhancement

Hi Joerg,

Just wondering if you will be able to take this for v5.10? There hasn't
been any material changes since we last discussed in LPC. We have VFIO and
other vSVA patches depending on it.

Thanks!

Jacob 

On Fri, 25 Sep 2020 09:32:41 -0700, Jacob Pan <jacob.pan.linux@...il.com>
wrote:

> IOMMU user API header was introduced to support nested DMA translation and
> related fault handling. The current UAPI data structures consist of three
> areas that cover the interactions between host kernel and guest:
>  - fault handling
>  - cache invalidation
>  - bind guest page tables, i.e. guest PASID
> 
> Future extensions are likely to support more architectures and vIOMMU
> features.
> 
> In the previous discussion, using user-filled data size and feature flags
> is made a preferred approach over a unified version number.
> https://lkml.org/lkml/2020/1/29/45
> 
> In addition to introduce argsz field to data structures, this patchset is
> also trying to document the UAPI design, usage, and extension rules. VT-d
> driver changes to utilize the new argsz field is included, VFIO usage is
> to follow.
> 
> This set is available at:
> https://github.com/jacobpan/linux.git vsva_v5.9_uapi_v12
> 
> Thanks,
> 
> Jacob
> 
> 
> Changelog:
> v12
> 	- Removed a redundant check in cache invalidate API
> v11
> 	- Use #define instead of enum in PASID data format, squashed
> change into "iommu/uapi: Handle data and argsz filled by users"
> 	- Remove alloc/free from documentation per Yi's comment. IOMMU
> UAPI does not perform IOASID alloc/free.
> v10
> 	- Documentation grammar fixes based on Randy's review
> v9
> 	- Directly pass PASID value to iommu_sva_unbind_gpasid() without
> 	  the superfluous data in struct iommu_gpasid_bind_data.
> v8
> 	- Rebased to v5.9-rc2
> 	- Addressed review comments from Eric Auger
> 	  1. added a check for the unused vendor flags
> 	  2. commit message improvements
> v7
> 	- Added PASID data format enum for range checking
> 	- Tidy up based on reviews from Alex W.
> 	- Removed doc section for vIOMMU fault handling
> v6
> 	- Renamed all UAPI functions with iommu_uapi_ prefix
> 	- Replaced argsz maxsz checking with flag specific size checks
> 	- Documentation improvements based on suggestions by Eric Auger
> 	  Replaced example code with a pointer to the actual code
> 	- Added more checks for illegal flags combinations
> 	- Added doc file to MAINTAINERS
> v5
> 	- Addjusted paddings in UAPI data to be 8 byte aligned
> 	- Do not clobber argsz in IOMMU core before passing on to vendor
> driver
> 	- Removed pr_warn_ for invalid UAPI data check, just return
> -EINVAL
> 	- Clarified VFIO responsibility in UAPI data handling
> 	- Use iommu_uapi prefix to differentiate APIs has in-kernel caller
> 	- Added comment for unchecked flags of invalidation granularity
> 	- Added example in doc to show vendor data checking
> 
> v4
> 	- Added checks of UAPI data for reserved fields, version, and
> flags.
> 	- Removed version check from vendor driver (vt-d)
> 	- Relaxed argsz check to match the UAPI struct size instead of
> variable union size
> 	- Updated documentation
> 
> v3:
> 	- Rewrote backward compatibility rule to support existing code
> 	  re-compiled with newer kernel UAPI header that runs on older
> 	  kernel. Based on review comment from Alex W.
> 	  https://lore.kernel.org/linux-iommu/20200611094741.6d118fa8@w520.home/
> 	- Take user pointer directly in UAPI functions. Perform argsz
> check and copy_from_user() in IOMMU driver. Eliminate the need for
> 	  VFIO or other upper layer to parse IOMMU data.
> 	- Create wrapper function for in-kernel users of UAPI functions
> v2:
> 	- Removed unified API version and helper
> 	- Introduced argsz for each UAPI data
> 	- Introduced UAPI doc
> 
> 
> Jacob Pan (6):
>   docs: IOMMU user API
>   iommu/uapi: Add argsz for user filled data
>   iommu/uapi: Use named union for user data
>   iommu/uapi: Rename uapi functions
>   iommu/uapi: Handle data and argsz filled by users
>   iommu/vt-d: Check UAPI data processed by IOMMU core
> 
>  Documentation/userspace-api/iommu.rst | 209
> ++++++++++++++++++++++++++++++++++ MAINTAINERS
> |   1 + drivers/iommu/intel/iommu.c           |  25 ++--
>  drivers/iommu/intel/svm.c             |  13 ++-
>  drivers/iommu/iommu.c                 | 196
> +++++++++++++++++++++++++++++-- include/linux/iommu.h                 |
> 35 ++++-- include/uapi/linux/iommu.h            |  18 ++-
>  7 files changed, 456 insertions(+), 41 deletions(-)
>  create mode 100644 Documentation/userspace-api/iommu.rst
> 


Thanks,

Jacob