linux-kernel - Re: [Freedreno] [PATCH] drm/msm/dpu: Add newline to printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ef9767b5088a9ce33aaceccae3f6d458@codeaurora.org>
Date:   Mon, 28 Sep 2020 12:21:36 -0700
From:   abhinavk@...eaurora.org
To:     Stephen Boyd <swboyd@...omium.org>
Cc:     Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Jeykumar Sankaran <jsanka@...eaurora.org>,
        freedreno@...ts.freedesktop.org
Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Add newline to printks

On 2020-09-28 12:16, Stephen Boyd wrote:
> Printk messages need newlines. Add it here.
> 
> Cc: Abhinav Kumar <abhinavk@...eaurora.org>
> Cc: Jeykumar Sankaran <jsanka@...eaurora.org>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Signed-off-by: Stephen Boyd <swboyd@...omium.org>
Reviewed-by: Abhinav Kumar <abhinavk@...eaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index f272a8d0f95b..cbe0461246f8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -906,7 +906,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc 
> *crtc,
>  	}
> 
>  	mode = &state->adjusted_mode;
> -	DPU_DEBUG("%s: check", dpu_crtc->name);
> +	DPU_DEBUG("%s: check\n", dpu_crtc->name);
> 
>  	/* force a full mode set if active state changed */
>  	if (state->active_changed)
> @@ -1012,7 +1012,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc 
> *crtc,
>  		}
> 
>  		pstates[i].dpu_pstate->stage = z_pos + DPU_STAGE_0;
> -		DPU_DEBUG("%s: zpos %d", dpu_crtc->name, z_pos);
> +		DPU_DEBUG("%s: zpos %d\n", dpu_crtc->name, z_pos);
>  	}
> 
>  	for (i = 0; i < multirect_count; i++) {