linux-kernel - Re: [net PATCH] octeontx2-af: Fix enable/disable of default NPC entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200928142837.0f529a24@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Mon, 28 Sep 2020 14:28:37 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Geetha sowjanya <gakula@...vell.com>
Cc:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <sgoutham@...vell.com>, <lcherian@...vell.com>,
        <jerinj@...vell.com>, <davem@...emloft.net>,
        Subbaraya Sundeep <sbhatta@...vell.com>
Subject: Re: [net PATCH] octeontx2-af: Fix enable/disable of default NPC
 entries

On Sat, 26 Sep 2020 12:27:00 +0530 Geetha sowjanya wrote:
> From: Subbaraya Sundeep <sbhatta@...vell.com>
> 
> Packet replication feature present in Octeontx2
> is a hardware linked list of PF and its VF
> interfaces so that broadcast packets are sent
> to all interfaces present in the list. It is
> driver job to add and delete a PF/VF interface
> to/from the list when the interface is brought
> up and down. This patch fixes the
> npc_enadis_default_entries function to handle
> broadcast replication properly if packet replication
> feature is present.
> 
> Fixes: 40df309e4166
> ("octeontx2-af: Support to enable/disable default MCAM entries")
> 
> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> Signed-off-by: Geetha sowjanya <gakula@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>

The patches look good, but could you please resend them with fixed
"Fixes" tags? The tag should be on one line with no empty line between
the tag and the signoffs. So the above should have looked like:

Fixes: 40df309e4166 ("octeontx2-af: Support to enable/disable default MCAM entries")
Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
Signed-off-by: Geetha sowjanya <gakula@...vell.com>
Signed-off-by: Sunil Goutham <sgoutham@...vell.com>