linux-kernel - Re: [PATCH AUTOSEL 4.14 112/127] perf parse-events: Fix incorrect conversion of 'if () free()' to 'zfree()'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200928220127.GE2219727@sasha-vm>
Date:   Mon, 28 Sep 2020 18:01:27 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     linux- stable <stable@...r.kernel.org>,
        Arnaldo Carvalho de Melo <acme@...hat.com>,
        open list <linux-kernel@...r.kernel.org>,
        Ian Rogers <irogers@...gle.com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        clang-built-linux@...glegroups.com, Jiri Olsa <jolsa@...nel.org>,
        Leo Yan <leo.yan@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        Namhyung Kim <namhyung@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Stephane Eranian <eranian@...gle.com>,
        lkft-triage@...ts.linaro.org
Subject: Re: [PATCH AUTOSEL 4.14 112/127] perf parse-events: Fix incorrect
 conversion of 'if () free()' to 'zfree()'

On Tue, Sep 29, 2020 at 01:24:32AM +0530, Naresh Kamboju wrote:
>On Fri, 18 Sep 2020 at 08:00, Sasha Levin <sashal@...nel.org> wrote:
>>
>> From: Arnaldo Carvalho de Melo <acme@...hat.com>
>>
>> [ Upstream commit 7fcdccd4237724931d9773d1e3039bfe053a6f52 ]
>>
>> When applying a patch by Ian I incorrectly converted to zfree() an
>> expression that involved testing some other struct member, not the one
>> being freed, which lead to bugs reproduceable by:
>>
>>   $ perf stat -e i/bs,tsc,L2/o sleep 1
>>   WARNING: multiple event parsing errors
>>   Segmentation fault (core dumped)
>>   $
>>
>> Fix it by restoring the test for pos->free_str before freeing
>> pos->val.str, but continue using zfree(&pos->val.str) to set that member
>> to NULL after freeing it.
>>
>> Reported-by: Ian Rogers <irogers@...gle.com>
>> Fixes: e8dfb81838b1 ("perf parse-events: Fix memory leaks found on parse_events")
>> Cc: Adrian Hunter <adrian.hunter@...el.com>
>> Cc: Alexander Shishkin <alexander.shishkin@...ux.intel.com>
>> Cc: Andi Kleen <ak@...ux.intel.com>
>> Cc: clang-built-linux@...glegroups.com
>> Cc: Jiri Olsa <jolsa@...nel.org>
>> Cc: Leo Yan <leo.yan@...aro.org>
>> Cc: Mark Rutland <mark.rutland@....com>
>> Cc: Namhyung Kim <namhyung@...nel.org>
>> Cc: Peter Zijlstra <peterz@...radead.org>
>> Cc: Stephane Eranian <eranian@...gle.com>
>> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
>> Signed-off-by: Sasha Levin <sashal@...nel.org>
>
>stable rc 4.14 perf build broken.

Dropped, thanks!

-- 
Thanks,
Sasha