linux-kernel - Re: [PATCH] arm64: dts: amlogic: meson-g12: use the G12A specific dwmac compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad3505a3-b409-48b9-c077-09ef4fdc7bbf@baylibre.com>
Date:   Mon, 28 Sep 2020 09:55:14 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-amlogic@...ts.infradead.org, khilman@...libre.com
Cc:     jbrunet@...libre.com, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: amlogic: meson-g12: use the G12A specific
 dwmac compatible

On 25/09/2020 23:17, Martin Blumenstingl wrote:
> We have a dedicated "amlogic,meson-g12a-dwmac" compatible string for the
> Ethernet controller since commit 3efdb92426bf4 ("dt-bindings: net:
> dwmac-meson: Add a compatible string for G12A onwards").
> Using the AXG compatible string worked fine so far because the
> dwmac-meson8b driver doesn't handle the newly introduced register bits
> for G12A. However, once that changes the driver must be probed with the
> correct compatible string to manage these new register bits.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index 1e83ec5b8c91..d4e7cd68170a 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -209,7 +209,7 @@ map {
>  		};
>  
>  		ethmac: ethernet@...f0000 {
> -			compatible = "amlogic,meson-axg-dwmac",
> +			compatible = "amlogic,meson-g12a-dwmac",
>  				     "snps,dwmac-3.70a",
>  				     "snps,dwmac";
>  			reg = <0x0 0xff3f0000 0x0 0x10000>,
> 

Reviewed-by: Neil Armstrong <narmstrong@...libre.com>