linux-kernel - RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt line pull-up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VE1PR04MB6638D590D325B4CEABB4806B89350@VE1PR04MB6638.eurprd04.prod.outlook.com>
Date:   Mon, 28 Sep 2020 08:06:10 +0000
From:   Robin Gong <yibin.gong@....com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Fabio Estevam <festevam@...il.com>,
        dl-linux-imx <linux-imx@....com>, Adam Ford <aford173@...il.com>,
        Daniel Baluta <daniel.baluta@....com>,
        Anson Huang <anson.huang@....com>,
        Peter Chen <peter.chen@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/6] arm64: dts: imx8mm-evk: fix missing PMIC's interrupt
 line pull-up

On 2020/09/28 1:00 Krzysztof Kozlowski <krzk@...nel.org> wrote:
> The PMIC's interrupt is level low and should be pulled up.  The PMIC's device
> node had pinctrl-0 property but it lacked pinctrl-names which is required to
> apply the pin configuration.
> 
> Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> Fixes: aa71d0648318 ("arm64: dts: imx8mm: Split the imx8mm evk board dts
> to a common dtsi")
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Please tag me with the whole patch set, thanks.
Reviewed-by: Robin Gong <yibin.gong@....com>

> ---
>  arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> index f305a530ff6f..521eb3a5a12e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
> @@ -121,6 +121,7 @@
>  	pmic@4b {
>  		compatible = "rohm,bd71847";
>  		reg = <0x4b>;
> +		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_pmic>;
>  		interrupt-parent = <&gpio1>;
>  		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> --
> 2.17.1