linux-kernel - Re: [PATCH] usb: bdc: Remove duplicate error message in bdc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20c1b250-bc9a-98fd-8029-99a4c92a1c94@cmss.chinamobile.com>
Date:   Mon, 28 Sep 2020 16:40:01 +0800
From:   Tang Bin <tangbin@...s.chinamobile.com>
To:     Chunfeng Yun <chunfeng.yun@...iatek.com>,
        Florian Fainelli <f.fainelli@...il.com>
Cc:     balbi@...nel.org, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: bdc: Remove duplicate error message in bdc_probe()


在 2020/9/28 14:49, Chunfeng Yun 写道:
> On Sun, 2020-09-27 at 21:42 +0800, Tang Bin wrote:
>> In this function, we don't need dev_err() message because
>> when something goes wrong, devm_platform_ioremap_resource()
>> can print an error message itself, so remove the redundant
>> one.
>>
>> Signed-off-by: Zhang Shengju <zhangshengju@...s.chinamobile.com>
>> Signed-off-by: Tang Bin <tangbin@...s.chinamobile.com>
>> ---
>>   drivers/usb/gadget/udc/bdc/bdc_core.c | 4 +---
>>   1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/udc/bdc/bdc_core.c b/drivers/usb/gadget/udc/bdc/bdc_core.c
>> index 02a3a7746..9454f179e 100644
>> --- a/drivers/usb/gadget/udc/bdc/bdc_core.c
>> +++ b/drivers/usb/gadget/udc/bdc/bdc_core.c
>> @@ -508,10 +508,8 @@ static int bdc_probe(struct platform_device *pdev)
>>   	bdc->clk = clk;
>>   
>>   	bdc->regs = devm_platform_ioremap_resource(pdev, 0);
>> -	if (IS_ERR(bdc->regs)) {
>> -		dev_err(dev, "ioremap error\n");
>> +	if (IS_ERR(bdc->regs))
>>   		return -ENOMEM;
>> -	}
>>   	irq = platform_get_irq(pdev, 0);
>>   	if (irq < 0)
>>   		return irq;
> Cc bdc's maintainer:  Florian Fainelli <f.fainelli@...il.com>

Got it, thanks.

Tang Bin

>
>