linux-kernel - RE: [PATCH 4/5 V4] PCI: only return true when dev io state is really changed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR11MB169613F1730CF795D8AB20A297350@MWHPR11MB1696.namprd11.prod.outlook.com>
Date:   Mon, 28 Sep 2020 01:47:28 +0000
From:   "Zhao, Haifeng" <haifeng.zhao@...el.com>
To:     Joe Perches <joe@...ches.com>,
        "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
        "oohall@...il.com" <oohall@...il.com>,
        "ruscur@...sell.cc" <ruscur@...sell.cc>,
        "lukas@...ner.de" <lukas@...ner.de>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>,
        "stuart.w.hayes@...il.com" <stuart.w.hayes@...il.com>,
        "mr.nuke.me@...il.com" <mr.nuke.me@...il.com>,
        "mika.westerberg@...ux.intel.com" <mika.westerberg@...ux.intel.com>
CC:     "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Jia, Pei P" <pei.p.jia@...el.com>,
        "ashok.raj@...ux.intel.com" <ashok.raj@...ux.intel.com>,
        "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@...el.com>,
        "hch@...radead.org" <hch@...radead.org>
Subject: RE: [PATCH 4/5 V4] PCI: only return true when dev io state is really
 changed

Sorry for that offence, I should ask for your permission. 

-----Original Message-----
From: Joe Perches <joe@...ches.com> 
Sent: Sunday, September 27, 2020 5:14 PM
To: Zhao, Haifeng <haifeng.zhao@...el.com>; bhelgaas@...gle.com; oohall@...il.com; ruscur@...sell.cc; lukas@...ner.de; andriy.shevchenko@...ux.intel.com; stuart.w.hayes@...il.com; mr.nuke.me@...il.com; mika.westerberg@...ux.intel.com
Cc: linux-pci@...r.kernel.org; linux-kernel@...r.kernel.org; Jia, Pei P <pei.p.jia@...el.com>; ashok.raj@...ux.intel.com; Kuppuswamy, Sathyanarayanan <sathyanarayanan.kuppuswamy@...el.com>; hch@...radead.org
Subject: Re: [PATCH 4/5 V4] PCI: only return true when dev io state is really changed

On Sun, 2020-09-27 at 04:27 -0400, Ethan Zhao wrote:
> When uncorrectable error happens, AER driver and DPC driver interrupt 
> handlers likely call
> 
>    pcie_do_recovery()
>    ->pci_walk_bus()
>      ->report_frozen_detected()
> 
> with pci_channel_io_frozen the same time.
>    If pci_dev_set_io_state() return true even if the original state is 
> pci_channel_io_frozen, that will cause AER or DPC handler re-enter the 
> error detecting and recovery procedure one after another.
>    The result is the recovery flow mixed between AER and DPC.
> So simplify the pci_dev_set_io_state() function to only return true 
> when dev->error_state is changed.
> 
> Signed-off-by: Ethan Zhao <haifeng.zhao@...el.com>
> Tested-by: Wen Jin <wen.jin@...el.com>
> Tested-by: Shanshan Zhang <ShanshanX.Zhang@...el.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reviewed-by: Alexandru Gagniuc <mr.nuke.me@...il.com>
> Reviewed-by: Joe Perches <joe@...ches.com>

Hi Ethan/Haifeng.

Like Andy, I did not "review" this patch and sign it.
I merely suggested another simplification.
Please do not add -by: lines unless actually received by you.