[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200928120500.GA8151@zn.tnic>
Date: Mon, 28 Sep 2020 14:05:00 +0200
From: Borislav Petkov <bp@...en8.de>
To: Shuah Khan <skhan@...uxfoundation.org>
Cc: mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
rric@...nel.org, gregkh@...uxfoundation.org, keescook@...omium.org,
linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] drivers/edac: convert pci counters to
counter_atomic32
On Fri, Sep 25, 2020 at 05:47:25PM -0600, Shuah Khan wrote:
> counter_atomic* is introduced to be used when a variable is used as
> a simple counter and doesn't guard object lifetimes. This clearly
> differentiates atomic_t usages that guard object lifetimes.
>
> counter_atomic* variables will wrap around to 0 when it overflows and
> should not be used to guard resource lifetimes, device usage and
> open counts that control state changes, and pm states.
>
> atomic_t variables used for pci counters keep track of pci parity and
> non-parity errors. Convert them to use counter_atomic32.
>
> Overflow will wrap around and reset the counts as was the case prior to
> the conversion.
>
> Signed-off-by: Shuah Khan <skhan@...uxfoundation.org>
> ---
> drivers/edac/edac_pci.h | 5 +++--
> drivers/edac/edac_pci_sysfs.c | 28 ++++++++++++++--------------
> 2 files changed, 17 insertions(+), 16 deletions(-)
The patches I was Cced - this one and the apei one, look ok to me.
Acked-by: Borislav Petkov <bp@...e.de>
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
Powered by blists - more mailing lists