linux-kernel - Re: [PATCH v4] mtd: parsers: bcm63xx: simplify CFE detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Sep 2020 16:16:17 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Álvaro Fernández Rojas 
        <noltari@...il.com>, linux-mips@...r.kernel.org,
        tsbogend@...ha.franken.de, Florian Fainelli <f.fainelli@...il.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>, jonas.gorski@...il.com,
        Linus Walleij <linus.walleij@...aro.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-mtd@...ts.infradead.org, lkft-triage@...ts.linaro.org
Subject: Re: [PATCH v4] mtd: parsers: bcm63xx: simplify CFE detection

Hello,

Guenter Roeck <linux@...ck-us.net> wrote on Mon, 21 Sep 2020 20:26:19
-0700:

> On 9/21/20 8:18 PM, Naresh Kamboju wrote:
> > On Fri, 14 Aug 2020 at 14:26, Guenter Roeck <linux@...ck-us.net> wrote:  
> >>
> >> On Mon, Jun 15, 2020 at 11:17:40AM +0200, Álvaro Fernández Rojas wrote:  
> >>> Instead of trying to parse CFE version string, which is customized by some
> >>> vendors, let's just check that "CFE1" was passed on argument 3.
> >>>
> >>> Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
> >>> Signed-off-by: Jonas Gorski <jonas.gorski@...il.com>
> >>> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>  
> >>  
> > 
> > We still see mips: allmodconfig build failure on Linus tree
> >   
> 
> Yes, same here.

Perhaps this check should be done by an exported helper so that we do
not blindly export the variable?

Alvaro, Jonas, can one of you try to address this issue please?

Thanks,
Miquèl