linux-kernel - Re: [PATCH] mtd: rawnand: ams-delta: Fix non-OF build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200928145957.9218-1-miquel.raynal@bootlin.com>
Date:   Mon, 28 Sep 2020 16:59:57 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Janusz Krzysztofik <jmkrzyszt@...il.com>,
        Miquel Raynal <miquel.raynal@...tlin.com>
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Richard Weinberger <richard@....at>,
        Nick Desaulniers <ndesaulniers@...gle.com>,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com,
        linux-mtd@...ts.infradead.org,
        Nathan Chancellor <natechancellor@...il.com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] mtd: rawnand: ams-delta: Fix non-OF build warning

On Sat, 2020-09-19 at 08:04:03 UTC, Janusz Krzysztofik wrote:
> Commit 7c2f66a960fc ("mtd: rawnand: ams-delta: Add module device
> tables") introduced an OF module device table but wrapped a reference
> to it with of_match_ptr() which resolves to NULL in non-OF configs.
> That resulted in a clang compiler warning on unused variable in non-OF
> builds.  Fix it.
> 
> drivers/mtd/nand/raw/ams-delta.c:373:34: warning: unused variable 'gpio_nand_of_id_table' [-Wunused-const-variable]
>    static const struct of_device_id gpio_nand_of_id_table[] = {
>                                     ^
>    1 warning generated.
> 
> Fixes: 7c2f66a960fc ("mtd: rawnand: ams-delta: Add module device tables")
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Janusz Krzysztofik <jmkrzyszt@...il.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks.

Miquel