linux-kernel - Re: [PATCH] rcu: Clarify nocb kthreads naming in RCU_NOCB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 27 Sep 2020 20:41:16 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     Neeraj Upadhyay <neeraju@...eaurora.org>, josh@...htriplett.org,
        rostedt@...dmis.org, mathieu.desnoyers@...icios.com,
        jiangshanlai@...il.com, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu: Clarify nocb kthreads naming in RCU_NOCB_CPU config

On Sun, Sep 27, 2020 at 08:13:42PM -0400, Joel Fernandes wrote:
> On Thu, Sep 24, 2020 at 12:04:10PM +0530, Neeraj Upadhyay wrote:
> > Clarify the "x" in rcuox/N naming in RCU_NOCB_CPU config
> > description.
> > 
> 
> Reviewed-by: Joel Fernandes (Google) <joel@...lfernandes.org>

Thank you, I will apply your Reviewed-by on the next rebase.

						Thanx, Paul

> thanks,
> 
>  - Joel
> 
> > Signed-off-by: Neeraj Upadhyay <neeraju@...eaurora.org>
> > ---
> >  kernel/rcu/Kconfig | 11 ++++++-----
> >  1 file changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
> > index b71e21f..5b22747 100644
> > --- a/kernel/rcu/Kconfig
> > +++ b/kernel/rcu/Kconfig
> > @@ -227,11 +227,12 @@ config RCU_NOCB_CPU
> >  	  specified at boot time by the rcu_nocbs parameter.  For each
> >  	  such CPU, a kthread ("rcuox/N") will be created to invoke
> >  	  callbacks, where the "N" is the CPU being offloaded, and where
> > -	  the "p" for RCU-preempt (PREEMPTION kernels) and "s" for RCU-sched
> > -	  (!PREEMPTION kernels).  Nothing prevents this kthread from running
> > -	  on the specified CPUs, but (1) the kthreads may be preempted
> > -	  between each callback, and (2) affinity or cgroups can be used
> > -	  to force the kthreads to run on whatever set of CPUs is desired.
> > +	  the "x" is "p" for RCU-preempt (PREEMPTION kernels) and "s" for
> > +	  RCU-sched (!PREEMPTION kernels).  Nothing prevents this kthread
> > +	  from running on the specified CPUs, but (1) the kthreads may be
> > +	  preempted between each callback, and (2) affinity or cgroups can
> > +	  be used to force the kthreads to run on whatever set of CPUs is
> > +	  desired.
> >  
> >  	  Say Y here if you want to help to debug reduced OS jitter.
> >  	  Say N here if you are unsure.
> > -- 
> > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> > a Linux Foundation Collaborative Project
> >