linux-kernel - Re: [PATCH v5 3/3] dt-bindings: leds: Convert pwm to yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqKYWC82OB9OVtwsBnKHpfDfRYATdYfGXc0hiQ2kAgoKJg@mail.gmail.com>
Date:   Tue, 29 Sep 2020 08:58:13 -0500
From:   Rob Herring <robh@...nel.org>
To:     Alexander Dahl <ada@...rsis.com>
Cc:     Alexander Dahl <post@...pocky.de>,
        Linux LED Subsystem <linux-leds@...r.kernel.org>,
        devicetree@...r.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Pavel Machek <pavel@....cz>, Dan Murphy <dmurphy@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Peter Ujfalusi <peter.ujfalusi@...com>,
        Marek Behún <marek.behun@....cz>
Subject: Re: [PATCH v5 3/3] dt-bindings: leds: Convert pwm to yaml

On Tue, Sep 29, 2020 at 2:39 AM Alexander Dahl <ada@...rsis.com> wrote:
>
> Hei hei,
>
> Am Dienstag, 22. September 2020, 17:57:47 CEST schrieb Rob Herring:
> > Use generic node names:
> >
> > led-controller {
> >
> > > +        compatible = "pwm-leds";
> > > +
> > > +        led-1 {
> > > +            label = "omap4::keypad";
> > > +            pwms = <&twl_pwm 0 7812500>;
> > > +            max-brightness = <127>;
> > > +        };
> > > +
> > > +        led-2 {
> > > +            color = <LED_COLOR_ID_GREEN>;
> > > +            function = LED_FUNCTION_CHARGING;
> > > +            pwms = <&twl_pwmled 0 7812500>;
> > > +            max-brightness = <255>;
> > > +        };
> > > +    };
> > > +
> > > +...
>
> This is clear for the "one led-controller" case.  However, when trying to fix
> those node names in existing .dts files, I wondered how those should be named
> for multiple, different led-controllers, e.g. one using "pwm-leds" and another
> one using "gpio-leds"?
>
> See arch/arm/boot/dts/at91-kizbox3-hs.dts for example, the nodes are called
> "pwm_leds" and "leds" currently.  If both were part of a .dtsi and both named
> the same, you could not overwrite/complement those in a .dts file including
> that .dtsi due to a name conflict.
>
> Just append a numerical index like this?
>
>   led-controller-1 {
>     …
>   };
>
>   led-controller-2 {
>     …
>   };

Yes, that's generally what we've been doing.

Rob