linux-kernel - Re: [PATCH 10/20] media: lmedm04: use semicolons rather than commas to separate statements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8d73748e-be82-4c30-4550-b5f4eecb3055@wanadoo.fr>
Date:   Tue, 29 Sep 2020 18:00:57 +0200
From:   Christophe JAILLET <christophe.jaillet@...adoo.fr>
To:     Julia Lawall <Julia.Lawall@...ia.fr>,
        Malcolm Priestley <tvboxspy@...il.com>
Cc:     Valdis Klētnieks <valdis.kletnieks@...edu>,
        Joe Perches <joe@...ches.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        kernel-janitors@...r.kernel.org,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/20] media: lmedm04: use semicolons rather than commas
 to separate statements

Le 29/09/2020 à 15:14, Julia Lawall a écrit :
> Replace commas with semicolons.  Commas introduce unnecessary
> variability in the code structure and are hard to see.  What is done
> is essentially described by the following Coccinelle semantic patch
> (http://coccinelle.lip6.fr/):
> 
> // <smpl>
> @@ expression e1,e2; @@
> e1
> -,
> +;
> e2
> ... when any
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>
> 
> ---
>   drivers/media/usb/dvb-usb-v2/lmedm04.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c
> index 5a7a9522d46d..9ddda8d68ee0 100644
> --- a/drivers/media/usb/dvb-usb-v2/lmedm04.c
> +++ b/drivers/media/usb/dvb-usb-v2/lmedm04.c
> @@ -391,7 +391,7 @@ static int lme2510_int_read(struct dvb_usb_adapter *adap)
>   	ep = usb_pipe_endpoint(d->udev, lme_int->lme_urb->pipe);
>   
>   	if (usb_endpoint_type(&ep->desc) == USB_ENDPOINT_XFER_BULK)
> -		lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa),
> +		lme_int->lme_urb->pipe = usb_rcvbulkpipe(d->udev, 0xa);
>   
>   	usb_submit_urb(lme_int->lme_urb, GFP_ATOMIC);
>   	info("INT Interrupt Service Started");
> 
> 
Ouch!

This one looks like a real issue!

CJ