lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 29 Sep 2020 10:51:06 +0100 From: Lee Jones <lee.jones@...aro.org> To: "David E. Box" <david.e.box@...ux.intel.com> Cc: dvhart@...radead.org, andy@...radead.org, alexander.h.duyck@...ux.intel.com, linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org Subject: Re: [PATCH 1/3] mfd: intel_pmt: Add OOBMSM device ID On Fri, 11 Sep 2020, David E. Box wrote: > Add Out of Band Management Services Module device ID to Intel PMT driver. > > Signed-off-by: Alexander Duyck <alexander.h.duyck@...ux.intel.com> > Signed-off-by: David E. Box <david.e.box@...ux.intel.com> > --- > drivers/mfd/intel_pmt.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mfd/intel_pmt.c b/drivers/mfd/intel_pmt.c > index 0e572b105101..8f9970ab3026 100644 > --- a/drivers/mfd/intel_pmt.c > +++ b/drivers/mfd/intel_pmt.c > @@ -55,6 +55,8 @@ struct pmt_platform_info { > unsigned long quirks; > }; > > +static const struct pmt_platform_info pmt_info; > + > static const struct pmt_platform_info tgl_info = { > .quirks = PMT_QUIRK_NO_WATCHER | PMT_QUIRK_NO_CRASHLOG | > PMT_QUIRK_TABLE_SHIFT, > @@ -200,8 +202,10 @@ static void pmt_pci_remove(struct pci_dev *pdev) > pm_runtime_get_sync(&pdev->dev); > } > > +#define PCI_DEVICE_ID_INTEL_PMT_OOBMSM 0x09a7 > #define PCI_DEVICE_ID_INTEL_PMT_TGL 0x9a0d > static const struct pci_device_id pmt_pci_ids[] = { > + { PCI_DEVICE_DATA(INTEL, PMT_OOBMSM, &pmt_info) }, Why are you supplying an empty struct? > { PCI_DEVICE_DATA(INTEL, PMT_TGL, &tgl_info) }, > { } > }; -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Powered by blists - more mailing lists