linux-kernel - Re: [PATCH] arm64: dts: zynqmp: Remove additional compatible string for i2c IPs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Sep 2020 12:56:39 +0200
From:   Michal Simek <monstr@...str.eu>
To:     LKML <linux-kernel@...r.kernel.org>,
        Michal Simek <monstr@...str.eu>, git <git@...inx.com>
Cc:     Krzysztof Kozlowski <krzk@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Manish Narani <manish.narani@...inx.com>,
        Michael Tretter <m.tretter@...gutronix.de>,
        Moritz Fischer <mdf@...nel.org>,
        Nava kishore Manne <nava.manne@...inx.com>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Rob Herring <robh+dt@...nel.org>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        DTML <devicetree@...r.kernel.org>,
        linux-arm <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] arm64: dts: zynqmp: Remove additional compatible string
 for i2c IPs

po 24. 8. 2020 v 10:59 odesílatel Michal Simek <michal.simek@...inx.com> napsal:
>
> DT binding permits only one compatible string which was decribed in past by
> commit 63cab195bf49 ("i2c: removed work arounds in i2c driver for Zynq
> Ultrascale+ MPSoC").
> The commit aea37006e183 ("dt-bindings: i2c: cadence: Migrate i2c-cadence
> documentation to YAML") has converted binding to yaml and the following
> issues is reported:
> ...: i2c@...30000: compatible: Additional items are not allowed
> ('cdns,i2c-r1p10' was unexpected)
>         From schema:
> .../Documentation/devicetree/bindings/i2c/cdns,i2c-r1p10.yaml fds
> ...: i2c@...30000: compatible: ['cdns,i2c-r1p14', 'cdns,i2c-r1p10'] is too
> long
>
> The commit c415f9e8304a ("ARM64: zynqmp: Fix i2c node's compatible string")
> has added the second compatible string but without removing origin one.
> The patch is only keeping one compatible string "cdns,i2c-r1p14".
>
> Fixes: c415f9e8304a ("ARM64: zynqmp: Fix i2c node's compatible string")
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 6a8ff4bcc09b..165a95a106c8 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -500,7 +500,7 @@ gpio: gpio@...a0000 {
>                 };
>
>                 i2c0: i2c@...20000 {
> -                       compatible = "cdns,i2c-r1p14", "cdns,i2c-r1p10";
> +                       compatible = "cdns,i2c-r1p14";
>                         status = "disabled";
>                         interrupt-parent = <&gic>;
>                         interrupts = <0 17 4>;
> @@ -511,7 +511,7 @@ i2c0: i2c@...20000 {
>                 };
>
>                 i2c1: i2c@...30000 {
> -                       compatible = "cdns,i2c-r1p14", "cdns,i2c-r1p10";
> +                       compatible = "cdns,i2c-r1p14";
>                         status = "disabled";
>                         interrupt-parent = <&gic>;
>                         interrupts = <0 18 4>;
> --
> 2.28.0
>

Applied.
M

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs