linux-kernel - Re: [PATCH] arm64: dts: zynqmp: Fix leds subnode name for zcu100/ultra96 v1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Sep 2020 13:01:32 +0200
From:   Michal Simek <monstr@...str.eu>
To:     U-Boot <u-boot@...ts.denx.de>, git <git@...inx.com>
Cc:     Anurag Kumar Vulisha <anurag.kumar.vulisha@...inx.com>,
        Rajan Vaja <rajan.vaja@...inx.com>,
        Rob Herring <robh+dt@...nel.org>,
        DTML <devicetree@...r.kernel.org>,
        linux-arm <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: zynqmp: Fix leds subnode name for
 zcu100/ultra96 v1

po 24. 8. 2020 v 12:28 odesílatel Michal Simek <michal.simek@...inx.com> napsal:
>
> Fix the leds subnode names to match (^led-[0-9a-f]$|led).
>
> Similar change has been also done by commit 08dc0e5dd9aa ("arm64: dts:
> meson: fix leds subnodes name").
>
> The patch is fixing this warning:
> avnet-ultra96-rev1.dt.yaml: leds: 'ds2', 'ds3', 'ds4', 'ds5' do not match
> any of the regexes: '(^led-[0-9a-f]$|led)', 'pinctrl-[0-9]+'
>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>
> ---
>
> vbus-det led is not fixed because it is not LED. It should be likely
> handled as gpio hog.
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> index d60110ad8367..2352dc553ba7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dts
> @@ -56,27 +56,27 @@ sw4 {
>
>         leds {
>                 compatible = "gpio-leds";
> -               ds2 {
> +               led-ds2 {
>                         label = "ds2";
>                         gpios = <&gpio 20 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger = "heartbeat";
>                 };
>
> -               ds3 {
> +               led-ds3 {
>                         label = "ds3";
>                         gpios = <&gpio 19 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger = "phy0tx"; /* WLAN tx */
>                         default-state = "off";
>                 };
>
> -               ds4 {
> +               led-ds4 {
>                         label = "ds4";
>                         gpios = <&gpio 18 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger = "phy0rx"; /* WLAN rx */
>                         default-state = "off";
>                 };
>
> -               ds5 {
> +               led-ds5 {
>                         label = "ds5";
>                         gpios = <&gpio 17 GPIO_ACTIVE_HIGH>;
>                         linux,default-trigger = "bluetooth-power";
> --
> 2.28.0
>

Applied.
M


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs