linux-kernel - Re: [PATCH V6 3/5] platform/x86: Intel PMT class driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKgT0Uc9LtFKnaHpzJhBLyeB_ycD74mb8wcaaO4KZBn+05Je5w@mail.gmail.com>
Date:   Tue, 29 Sep 2020 12:12:27 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     "David E. Box" <david.e.box@...ux.intel.com>,
        Lee Jones <lee.jones@...aro.org>, dvhart@...radead.org,
        Andy Shevchenko <andy@...radead.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Alexander Duyck <alexander.h.duyck@...ux.intel.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Alexey Budankov <alexey.budankov@...ux.intel.com>,
        LKML <linux-kernel@...r.kernel.org>,
        platform-driver-x86@...r.kernel.org,
        linux-pci <linux-pci@...r.kernel.org>
Subject: Re: [PATCH V6 3/5] platform/x86: Intel PMT class driver

On Mon, Sep 28, 2020 at 6:24 PM Randy Dunlap <rdunlap@...radead.org> wrote:
>
> On 9/28/20 5:53 PM, David E. Box wrote:
> > diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> > index 40219bba6801..093c43b63f48 100644
> > --- a/drivers/platform/x86/Kconfig
> > +++ b/drivers/platform/x86/Kconfig
> > @@ -1360,6 +1360,15 @@ config INTEL_PMC_CORE
> >               - LTR Ignore
> >               - MPHY/PLL gating status (Sunrisepoint PCH only)
> >
> > +config INTEL_PMT_CLASS
> > +     tristate "Intel Platform Monitoring Technology (PMT) Class driver"
> > +     help
> > +       The Intel Platform Monitoring Technology (PMT) class driver provides
> > +       the basic sysfs interface and file heirarchy uses by PMT devices.
>
>                                              hierarchy
> No "heir" involved.

Knowing me I probably had class inheritance on the mind at the time
when I was writing it up and it was just a thinko.. :-)

Thanks for the review feedback. I'll work with David to make sure we
address the formatting/spelling issues in this patch and the crashlog
patch.

- Alex