linux-kernel - Re: [PATCH v2 1/7] powerpc: Remove SYNC on non 6xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5f3a957-f9e0-4bf6-1d4a-41ccfa173366@csgroup.eu>
Date:   Tue, 29 Sep 2020 08:46:55 +0200
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/7] powerpc: Remove SYNC on non 6xx



Le 29/09/2020 à 08:09, Christophe Leroy a écrit :
> SYNC is usefull for Powerpc 601 only. On everything else,
> SYNC is empty.
> 
> Remove it from code that is not made to run on 6xx.
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>

Oops, the last patch of the series is missing. Will resend, sorry for the noise.

Christophe

> ---
>   arch/powerpc/kernel/head_40x.S   | 1 -
>   arch/powerpc/kernel/head_booke.h | 1 -
>   arch/powerpc/kernel/misc_64.S    | 1 -
>   3 files changed, 3 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/head_40x.S b/arch/powerpc/kernel/head_40x.S
> index 5b282d9965a5..44c9018aed1b 100644
> --- a/arch/powerpc/kernel/head_40x.S
> +++ b/arch/powerpc/kernel/head_40x.S
> @@ -72,7 +72,6 @@ turn_on_mmu:
>   	lis	r0,start_here@h
>   	ori	r0,r0,start_here@l
>   	mtspr	SPRN_SRR0,r0
> -	SYNC
>   	rfi				/* enables MMU */
>   	b	.			/* prevent prefetch past rfi */
>   
> diff --git a/arch/powerpc/kernel/head_booke.h b/arch/powerpc/kernel/head_booke.h
> index 18f87bf9e32b..71c359d438b5 100644
> --- a/arch/powerpc/kernel/head_booke.h
> +++ b/arch/powerpc/kernel/head_booke.h
> @@ -176,7 +176,6 @@ ALT_FTR_SECTION_END_IFSET(CPU_FTR_EMB_HV)
>   #endif
>   	mtspr	SPRN_SRR1,r10
>   	mtspr	SPRN_SRR0,r11
> -	SYNC
>   	RFI				/* jump to handler, enable MMU */
>   99:	b	ret_from_kernel_syscall
>   .endm
> diff --git a/arch/powerpc/kernel/misc_64.S b/arch/powerpc/kernel/misc_64.S
> index 7bb46ad98207..070465825c21 100644
> --- a/arch/powerpc/kernel/misc_64.S
> +++ b/arch/powerpc/kernel/misc_64.S
> @@ -365,7 +365,6 @@ _GLOBAL(kexec_smp_wait)
>   
>   	li	r4,KEXEC_STATE_REAL_MODE
>   	stb	r4,PACAKEXECSTATE(r13)
> -	SYNC
>   
>   	b	kexec_wait
>   
>