linux-kernel - Re: [PATCH] platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b2b61349-db5c-07dd-0d55-84d7a7d54492@collabora.com>
Date:   Tue, 29 Sep 2020 09:54:59 +0200
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Wang Qing <wangqing@...o.com>, Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>,
        Mark Brown <broonie@...nel.org>,
        Tzung-Bi Shih <tzungbi@...gle.com>,
        Pi-Hsun Shih <pihsun@...omium.org>,
        Prashant Malani <pmalani@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform_data: ti: fix a typo

Hi Wang Qing,

Thank you for your patch.

On 26/9/20 4:49, Wang Qing wrote:
> Modify the typo: "compliment" -> "complement".
> 
> Signed-off-by: Wang Qing <wangqing@...o.com>
> ---
>  include/linux/platform_data/cros_ec_commands.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/platform_data/cros_ec_commands.h b/include/linux/platform_data/cros_ec_commands.h
> index 1fcfe9e..42203ce
> --- a/include/linux/platform_data/cros_ec_commands.h
> +++ b/include/linux/platform_data/cros_ec_commands.h
> @@ -261,12 +261,12 @@
>  /* Memory space version; set to EC_ACPI_MEM_VERSION_CURRENT */
>  #define EC_ACPI_MEM_VERSION            0x00
>  /*
> - * Test location; writing value here updates test compliment byte to (0xff -
> + * Test location; writing value here updates test complement byte to (0xff -
>   * value).
>   */
>  #define EC_ACPI_MEM_TEST               0x01
> -/* Test compliment; writes here are ignored. */
> -#define EC_ACPI_MEM_TEST_COMPLIMENT    0x02
> +/* Test complement; writes here are ignored. */
> +#define EC_ACPI_MEM_TEST_COMPLEMENT    0x02
>  

Although there is a typo, we did an effort to have cros_ec_command synced with
ec commands in the firmware code, so I'd like to see this change also applied on
the EC code. Do you mind to populate this change in the EC firmware code [1], please

[1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/master

Thanks,
  Enric


>  /* Keyboard backlight brightness percent (0 - 100) */
>  #define EC_ACPI_MEM_KEYBOARD_BACKLIGHT 0x03
>