linux-kernel - Re: [PATCH v10 00/20] gpio: cdev: add uAPI v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75Vdc4eVA6nLJNhH3R2LVvh4ibuVohmQMURiwPb4WxA_84Q@mail.gmail.com>
Date:   Tue, 29 Sep 2020 19:22:13 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Kent Gibson <warthog618@...il.com>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v10 00/20] gpio: cdev: add uAPI v2

On Tue, Sep 29, 2020 at 6:13 PM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
>
> On Mon, Sep 28, 2020 at 2:28 AM Kent Gibson <warthog618@...il.com> wrote:
> >
> > This patchset defines and implements a new version of the
> > GPIO CDEV uAPI to address existing 32/64-bit alignment issues, add
> > support for debounce, event sequence numbers, and allow for requested
> > lines with different configurations.
> > It provides some future proofing by adding optional configuration fields
> > and padding reserved for future use.
> >
> > The series can be partitioned into three blocks; the first two patches
> > are minor fixes that impact later patches, the next eleven contain the
> > v2 uAPI definition and implementation, and the final seven port the GPIO
> > tools to the v2 uAPI and extend them to use new uAPI features.
> >
> > The more complicated patches include their own commentary where
> > appropriate.

> This series looks great now. Unless there are new objections I intend
> on picking it up tomorrow.

Various nit-picks, if any, can be addressed later on.

-- 
With Best Regards,
Andy Shevchenko