linux-kernel - Re: [likely PATCH] media: lmedm04: Fix misuse of comma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200929190953.2f621541@coco.lan>
Date:   Tue, 29 Sep 2020 19:09:53 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Malcolm Priestley <tvboxspy@...il.com>
Cc:     Joe Perches <joe@...ches.com>, LKML <linux-kernel@...r.kernel.org>,
        linux-media <linux-media@...r.kernel.org>,
        Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [likely PATCH] media: lmedm04: Fix misuse of comma

Em Mon, 24 Aug 2020 21:01:12 +0100
Malcolm Priestley <tvboxspy@...il.com> escreveu:

> Good catch the interrupt URB is not running because usb_submit_urb is tangled with it.
> 
> It only really affects signal strength.

Yeah, that indeed sounds to be a real bug.

> 
> add
> 
> Fixes: 15e1ce33182d ("[media] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe 1 != type 3 in interrupt urb")
> Cc: <stable@...r.kernel.org>
> 
> Regards
> 
> 
> Malcolm

That's said, while here, it sounds weird to use GFP_ATOMIC instead
of GFP_KERNEL for the URB submissions. 

Malcolm,

if you still have the hardware for testing, could you please
check if replacing them by GFP_KERNEL will work?

Thanks!
Mauro

Thanks,
Mauro