linux-kernel - Re: [PATCH v4 01/16] bcm-vk: add bcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Sep 2020 19:08:56 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Scott Branden <scott.branden@...adcom.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Kees Cook <keescook@...omium.org>,
        linux-kernel@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com
Subject: Re: [PATCH v4 01/16] bcm-vk: add bcm_vk UAPI

On Tue, Sep 29, 2020 at 09:44:51AM -0700, Scott Branden wrote:
> 
> 
> On 2020-09-29 3:25 a.m., Greg Kroah-Hartman wrote:
> > On Mon, Sep 28, 2020 at 05:11:54PM -0700, Scott Branden wrote:
> >> Add user space api for bcm-vk driver.
> >>
> >> Provide ioctl api to load images and issue reset command to card.
> >> FW status registers in PCI BAR space also defined as part
> >> of API so that user space is able to interpret these memory locations
> >> as needed via direct PCIe access.
> >>
> >> Signed-off-by: Scott Branden <scott.branden@...adcom.com>
> >> ---
> >>  include/uapi/linux/misc/bcm_vk.h | 84 ++++++++++++++++++++++++++++++++
> >>  1 file changed, 84 insertions(+)
> >>  create mode 100644 include/uapi/linux/misc/bcm_vk.h
> >>
> >> diff --git a/include/uapi/linux/misc/bcm_vk.h b/include/uapi/linux/misc/bcm_vk.h
> >> new file mode 100644
> >> index 000000000000..5f1fc403bc67
> >> --- /dev/null
> >> +++ b/include/uapi/linux/misc/bcm_vk.h
> >> @@ -0,0 +1,84 @@
> >> +/* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */
> > Why do you need BSD-2 if you already have the syscall-note license?
> We include the header file outside of linux user space and use the defines in BSD and other code.
> Hence releasing the header as BSD-2 as well.

Are you _sure_ you need that extra license?  I ask as this is not the
"norm" for Linux api .h files.

Also note, given that you are the copyright holder, you can provide a
version in any other license in any other project, no need to put it
here.

I recommend going and talking to your license lawyers about this.

thanks,

greg k-h