linux-kernel - Re: [PATCH v3 0/9] iio: remove iio_buffer_set_attrs() and assign buffer attrs during alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Sep 2020 16:09:00 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Eugen Hristev <eugen.hristev@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Benson Leung <bleung@...omium.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        groeck@...omium.org,
        Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>,
        Gwendal Grignou <gwendal@...omium.org>
Subject: Re: [PATCH v3 0/9] iio: remove iio_buffer_set_attrs() and assign
 buffer attrs during alloc

On Tue, Sep 29, 2020 at 3:55 PM Alexandru Ardelean
<alexandru.ardelean@...log.com> wrote:
>
> This is a v2 & v3 for [1]:
>   https://lore.kernel.org/linux-iio/20200925083743.46469-1-alexandru.ardelean@analog.com/
>
> It also includes a at91-sama5d2_adc cleanup patch in this series:
>   https://lore.kernel.org/linux-iio/20200924102902.136169-1-alexandru.ardelean@analog.com/
> This patch is required, in order to make the removal of
> iio_buffer_set_attrs() a bit cleaner in the at91-sama5d2_adc driver.
>
> Following the discussion from [1], this patchset implements the
> following:

Makes sense to me, FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenjko>

>
> Changelog v2 -> v3:
> * in patch 'iio: buffer: dmaengine: unwrap the use of iio_buffer_set_attrs()'
>   - minor stylistic change;
>
> Changelog v1 -> v2:
> * rename '{devm_}iio_triggered_buffer_setup()' ->
>          '{devm_}iio_triggered_buffer_setup_ext()'
>   - wrap with macros the new ext functions to preserve backwards
>     compatibility
>   - add a new parameter to the ext functions, which are the
>     buffer->attrs
> * split into separate patches the removal [from each driver] of
>   iio_buffer_set_attrs() and the switch to a
>   {devm_}iio_triggered_buffer_setup_ext variant
> * add patch to remove iio_buffer_set_attrs() from DMAEngine IIO buffer
> * remove the iio_buffer_set_attrs() helper in a final/separate patch
> * add 'at91-sama5d2_adc: merge buffer & trigger' patch in this series,
>   so that the removal of iio_buffer_set_attrs() is easier to view
>
> Alexandru Ardelean (9):
>   iio: buffer: dmaengine: unwrap the use of iio_buffer_set_attrs()
>   iio: adc: at91-sama5d2_adc: merge buffer & trigger init into a
>     function
>   iio: triggered-buffer: add {devm_}iio_triggered_buffer_setup_ext
>     variants
>   iio: accel: adxl372: use devm_iio_triggered_buffer_setup_ext()
>   iio: accel: bmc150: use iio_triggered_buffer_setup_ext()
>   iio: adc: at91-sama5d2_adc: use devm_iio_triggered_buffer_setup_ext()
>   iio: cros_ec: use devm_iio_triggered_buffer_setup_ext()
>   iio: hid-sensors: use iio_triggered_buffer_setup_ext()
>   iio: buffer: remove iio_buffer_set_attrs() helper
>
>  drivers/iio/accel/adxl372.c                   | 11 ++-
>  drivers/iio/accel/bmc150-accel-core.c         | 25 +++---
>  drivers/iio/adc/at91-sama5d2_adc.c            | 82 +++++++++----------
>  .../buffer/industrialio-buffer-dmaengine.c    |  3 +-
>  .../buffer/industrialio-triggered-buffer.c    | 31 ++++---
>  .../cros_ec_sensors/cros_ec_sensors_core.c    | 15 ++--
>  .../common/hid-sensors/hid-sensor-trigger.c   | 22 ++---
>  drivers/iio/industrialio-buffer.c             | 12 ---
>  include/linux/iio/buffer.h                    |  3 -
>  include/linux/iio/triggered_buffer.h          | 23 ++++--
>  10 files changed, 113 insertions(+), 114 deletions(-)
>
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko