linux-kernel - Re: [PATCH v4] tools lib traceevent: Hide non API functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200930125027.7e54b71c@gandalf.local.home>
Date:   Wed, 30 Sep 2020 12:50:27 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     "Tzvetomir Stoyanov (VMware)" <tz.stoyanov@...il.com>
Cc:     arnaldo.melo@...il.com, linux-trace-devel@...r.kernel.org,
        ben@...adent.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] tools lib traceevent: Hide non API functions

On Wed, 30 Sep 2020 14:07:33 +0300
"Tzvetomir Stoyanov (VMware)" <tz.stoyanov@...il.com> wrote:

> There are internal library functions, which are not declared as a static.
> They are used inside the library from different files. Hide them from
> the library users, as they are not part of the API.
> These functions are made hidden and are renamed without the prefix "tep_":
>  tep_free_plugin_paths
>  tep_peek_char
>  tep_buffer_init
>  tep_get_input_buf_ptr
>  tep_get_input_buf
>  tep_read_token
>  tep_free_token
>  tep_free_event
>  tep_free_format_field
>  __tep_parse_format
> 
> Link: https://lore.kernel.org/linux-trace-devel/e4afdd82deb5e023d53231bb13e08dca78085fb0.camel@decadent.org.uk/
> Reported-by: Ben Hutchings <ben@...adent.org.uk>
> Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@...il.com>
> ---

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

Arnaldo,

Can you pull this in?

Thanks!

-- Steve